Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Message-ID: <1257792151.1230718964328.JavaMail.jira@brutus>
Date: Wed, 31 Dec 2008 02:22:44 -0800 (PST)
From: "Christian Schneider (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Subject: [jira] Commented: (CXF-1943) jms transport doesn't support to
 inject  jmsconfig to JmsDestination
In-Reply-To: <1255707971.1229066444556.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CXF-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660059#action_12660059 ] 

Christian Schneider commented on CXF-1943:
------------------------------------------

Hi,

I left out the parsing of JmsConfig reference in the JMSDestinationBeanDefinitionParser as I think it would be better to set the config in the jaxws:client or jaxws:endpoint. The JmsConfigFeature was meant as a first non intrusive way to add the config to client and endpoint. Ideally
I would think of something like:

<jaxws:client>
  <transport-config-ref="jmsConfig">
</jaxws:client>

I do not like the current policy of doing transport configs in conduit and destination as it is quite difficult for a beginner to build for example the destination name from namespace and endpoint name. Referencing the config in a spring like ref is much easier.

I read on the mailing list that one reason for having destination and conduit is that you can use something like name="http://namespace/*" but I have never seen that in projects.

Apart from this I think the solution Willem did should work quite well and allows setting the jms config from destination and conduit. But for the long run my proposal would be to dump conduit and destination in the spring configs and instead introduce a transport-config element for client and server.

What are your opinions about this? 


> jms transport doesn't support to inject  jmsconfig to JmsDestination
> --------------------------------------------------------------------
>
>                 Key: CXF-1943
>                 URL: https://issues.apache.org/jira/browse/CXF-1943
>             Project: CXF
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 2.0.9, 2.1.3
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.0.10, 2.1.4, 2.2
>
>
> A quick look the schema and JMSDestinationBeanDefinitionParser , there is no code for the jmsconfig injection.
> We also need to add a test to verify it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.