Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Message-ID: <963617551.1223821484304.JavaMail.jira@brutus>
Date: Sun, 12 Oct 2008 07:24:44 -0700 (PDT)
From: "Benson Margulies (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Subject: [jira] Commented: (CXF-1857) ServiceFactoryBean should not call
 createInvoker() twice if its invoker does not be set
In-Reply-To: <1523308221.1223818247432.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CXF-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638849#action_12638849 ] 

Benson Margulies commented on CXF-1857:
---------------------------------------

While you are here, how about CXF-1807?

> ServiceFactoryBean should not call createInvoker() twice if its invoker does not be set
> ---------------------------------------------------------------------------------------
>
>                 Key: CXF-1857
>                 URL: https://issues.apache.org/jira/browse/CXF-1857
>             Project: CXF
>          Issue Type: Improvement
>    Affects Versions: 2.0.3, 2.0.4, 2.0.5, 2.1, 2.0.6, 2.1.1, 2.0.7, 2.0.8, 2.1.2
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.1.3, 2.2
>
>
>  public Server create() {
>         try {
>             applyExtraClass();
>             if (serviceBean != null && getServiceClass() == null) {
>                 setServiceClass(ClassHelper.getRealClass(serviceBean));
>             }
>             if (invoker != null) {
>                 getServiceFactory().setInvoker(invoker);
>             } else if (serviceBean != null) {
>                  // we should set the invoker here
>                 getServiceFactory().setInvoker(createInvoker());               
>             }
>             Endpoint ep = createEndpoint();
>             server = new ServerImpl(getBus(),
>                                     ep,
>                                     getDestinationFactory(),
>                                     getBindingFactory());
>             if (ep.getService().getInvoker() == null) {
>                 if (invoker == null) {
>                     ep.getService().setInvoker(createInvoker());
>                 } else {
>                     ep.getService().setInvoker(invoker);
>                 }
>             }
>             if (start) {
>                 server.start();
>             }
>         } catch (EndpointException e) {
>             throw new ServiceConstructionException(e);
>         } catch (BusException e) {
>             throw new ServiceConstructionException(e);
>         } catch (IOException e) {
>             throw new ServiceConstructionException(e);
>         }
>         if (serviceBean != null) {
>             initializeAnnotationInterceptors(server.getEndpoint(),
>                                              ClassHelper.getRealClass(getServiceBean()));
>         } else if (getServiceClass() != null) {
>             initializeAnnotationInterceptors(server.getEndpoint(), getServiceClass());
>         }
>         applyFeatures();
>         return server;
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.