Mailing-List: contact issues-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Message-ID: <620322290.1213189965000.JavaMail.jira@brutus>
Date: Wed, 11 Jun 2008 06:12:45 -0700 (PDT)
From: "Andreas Benneke (JIRA)" <jira@apache.org>
To: issues@cxf.apache.org
Subject: [jira] Updated: (CXF-1645) ResourceInjector fails to inject into
 (Spring) proxies if resource to be in injected is subclassed
In-Reply-To: <980238715.1213189725027.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CXF-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Benneke updated CXF-1645:
---------------------------------

    Attachment: ResourceInjector.patch

This patch adds the proposed change to the ResourceInjector and extends the unit test to cover the specified case .

(Note: the test fails with the unpatched ResourceInjector)

> ResourceInjector fails to inject into (Spring) proxies if resource to be in injected is subclassed
> --------------------------------------------------------------------------------------------------
>
>                 Key: CXF-1645
>                 URL: https://issues.apache.org/jira/browse/CXF-1645
>             Project: CXF
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.1, 2.0.6, 2.1.1, 2.0.7
>            Reporter: Andreas Benneke
>         Attachments: ResourceInjector.patch
>
>
> If the target is a proxy ResourceInjector tries to resolve an appropriate setter method for the resource using 
>   Method targetMethod = getTarget().getClass().getMethod(method.getName(), new Class[]{resource.getClass()});
>   targetMethod.invoke(getTarget(), resource);
> This fails if the resource has been subclassed because getMethod() (still) does only exact matches (see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4287725).
> This is (for example) the reason why injecting the WebServiceContext into a (Spring) proxy does not work: The real implementation WebServiceContextImpl is always a subclass (see thread http://www.mail-archive.com/cxf-user@incubator.apache.org/msg03050.html)
> As a solutions, the ResourceInjector might implement it's own matching algorithm or e. g. use Spring's MethodInvoker instead which already contains such an algorithm:
>   MethodInvoker targetInvoker = new MethodInvoker();
>   targetInvoker.setTargetObject(getTarget());
>   targetInvoker.setTargetMethod(method.getName());
>   targetInvoker.setArguments(new Object[]{resource});
>   targetInvoker.prepare();
>   targetInvoker.invoke();

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.