cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard Opalka (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CXF-1623) Wrong method implementation in AnnotationHandlerChainBuilder
Date Mon, 02 Jun 2008 14:31:45 GMT

    [ https://issues.apache.org/jira/browse/CXF-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601639#action_12601639
] 

Richard Opalka commented on CXF-1623:
-------------------------------------

The questions are:

Q1: Is this method implementation correct?

I personally think yes but it has wrong preconditions.
It expects id to be one of 5 enumerated values there.

Q2: Is the hack in JaxWsServerFactoryBean.createBindingInfo() method necessary?

At least I know this hack breaks the above method (it's preconditions).
I'm talking about this piece of code:
        ...
        if (binding == null) {
            binding = jaxBid;
            setBindingId(binding); // this sets correct value first (in my case "http://schemas.xmlsoap.org/wsdl/soap/http"
        }
        
        if (binding.equals(SOAPBinding.SOAP11HTTP_BINDING) 
            || binding.equals(SOAPBinding.SOAP11HTTP_MTOM_BINDING)
            //|| binding.equals(SOAPBinding.SOAP12HTTP_BINDING) 
            || binding.equals(SOAPBinding.SOAP12HTTP_MTOM_BINDING)) {
            binding = "http://schemas.xmlsoap.org/soap/";
            setBindingId(binding); // but here this hack resets this value to "http://schemas.xmlsoap.org/soap/"
and this hacked value later in the execution breaks AnnotationHandlerChainBuilder.protocolMatches()
method preconditions
         ...

> Wrong method implementation in AnnotationHandlerChainBuilder
> ------------------------------------------------------------
>
>                 Key: CXF-1623
>                 URL: https://issues.apache.org/jira/browse/CXF-1623
>             Project: CXF
>          Issue Type: Sub-task
>            Reporter: Richard Opalka
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message