cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Kulp (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CXF-1083) LogUtils is missing some MissingResourceException handling
Date Mon, 01 Oct 2007 14:40:51 GMT

    [ https://issues.apache.org/jira/browse/CXF-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531522
] 

Daniel Kulp commented on CXF-1083:
----------------------------------

Freeman,

I don't think so.    If the user is explicitly setting a bundle name instead of using the
defaults, that bundle definitely should be there.    Allowing the exception is the right thing
in that case. 

Basically, when using the j.u.l.Logger stuff, that is what happens.   If you don't specify
a bundle name, it will catch the MissingResourceException and then retry with null.    If
you DO specify a bundle name, we don't retry.


That said, we should catch the InvocationTargetException and pull the MissingResourceException
out and throw that instead.  I'll handle that.



Dan

> LogUtils is missing some MissingResourceException handling
> ----------------------------------------------------------
>
>                 Key: CXF-1083
>                 URL: https://issues.apache.org/jira/browse/CXF-1083
>             Project: CXF
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.2
>            Reporter: benson margulies
>            Assignee: Daniel Kulp
>            Priority: Blocker
>
> In LogUtils.createLogger, there is no handling for MissingResourceException when there
is a custom logger class.
> The Log4jClass, delegating to the Abstract class, gets just the same collection of missing
resource exceptions as the default case. So it blows up.
> The code in createLogger only fails to handle if the name is non-null. If the name is
null, it has a try block. Looks to me as if the == null test is backwards.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message