Return-Path: Delivered-To: apmail-incubator-cxf-issues-archive@locus.apache.org Received: (qmail 79401 invoked from network); 25 Jul 2007 13:22:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 25 Jul 2007 13:22:55 -0000 Received: (qmail 97108 invoked by uid 500); 25 Jul 2007 13:22:54 -0000 Delivered-To: apmail-incubator-cxf-issues-archive@incubator.apache.org Received: (qmail 96965 invoked by uid 500); 25 Jul 2007 13:22:53 -0000 Mailing-List: contact cxf-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cxf-dev@incubator.apache.org Delivered-To: mailing list cxf-issues@incubator.apache.org Received: (qmail 96948 invoked by uid 99); 25 Jul 2007 13:22:53 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jul 2007 06:22:53 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jul 2007 06:22:51 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 52A317141F0 for ; Wed, 25 Jul 2007 06:22:31 -0700 (PDT) Message-ID: <21029873.1185369751336.JavaMail.jira@brutus> Date: Wed, 25 Jul 2007 06:22:31 -0700 (PDT) From: "Dan Diephouse (JIRA)" To: cxf-issues@incubator.apache.org Subject: [jira] Commented: (CXF-800) Resouce matching in jra seems incorrect In-Reply-To: <12227469.1184616904717.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CXF-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515291 ] Dan Diephouse commented on CXF-800: ----------------------------------- Just an update: I've take a look into this. unfortunately your proposed fix doesn't solve things. I am still working on a fix though and will keep you posted when one is available. > Resouce matching in jra seems incorrect > --------------------------------------- > > Key: CXF-800 > URL: https://issues.apache.org/jira/browse/CXF-800 > Project: CXF > Issue Type: Bug > Components: Core > Affects Versions: 2.0 > Environment: Windows XP, Java 1.5 > Reporter: Derek Shaw > Assignee: Dan Diephouse > > For me, this resource > @Get > @HttpResource(location = "/player/most/comments/{maxCount}") > @WebResult(name = "PlayerList") > public List getMostCommented(@WebParam(name = "maxCount") int maxCount); > Is matching this resource > @Get > @HttpResource(location = "/player/{ID}") > @WebResult(name = "Player") > public Player getPlayer(@WebParam(name = "ID") int ID) throws PlayerNotFoundFault; > The reason is that in ResourceUtil.java on line 38 > if (i == resource.length()) { > // if } is the last part of the resource, assume the > // rest of the request uri matches > return reqUri.length(); > } > This seems incorrect to me ( could easily be wrong here ) seem like since you are assuming '}' to be the end, then you should return resource.length() and not the request lenght. > Later when the correct resource ( the one that matches reqUri) is sent in, we already have a bestMatch = reqUri.lenth and the the check in URIMapper.java at line 46 does a > test so does not use the correct match. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.