Mailing-List: contact cxf-issues-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cxf-dev@incubator.apache.org
Message-ID: <20359617.1170140253537.JavaMail.jira@brutus>
Date: Mon, 29 Jan 2007 22:57:33 -0800 (PST)
From: "Bozhong Lin (JIRA)" <jira@apache.org>
To: cxf-issues@incubator.apache.org
Subject: [jira] Updated: (CXF-323) Improper synchronization of
 getDefaultBus(), setDefaultBus()
In-Reply-To: <15051495.1166761641087.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CXF-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bozhong Lin updated CXF-323:
----------------------------

    Assignee:     (was: willem Jiang)

> Improper synchronization of getDefaultBus(), setDefaultBus()
> ------------------------------------------------------------
>
>                 Key: CXF-323
>                 URL: https://issues.apache.org/jira/browse/CXF-323
>             Project: CXF
>          Issue Type: Bug
>            Reporter: Jarek Gawor
>
> getDefaultBus() method in org.apache.cxf.bus.spring.SpringBusFactory and org.apache.cxf.bus.cxf.CXFBusFactory is improperly synchronized. The method is instance-level synchronized while it initializes and accesses a class-level variable. Two different instances of BusFactory each calling getDefaultBus() at the same time could return two different Bus instances...
> This method should either be changed to 'public static synchronized Bus getDefaultBus()' or modified as for an example:
> public Bus getDefaultBus() {
>   return initDefaultBus();
> }
> private static synchronized Bus initDefaultBus() {
>   if (null == defaultBus) {
>          defaultBus = new CXFBusImpl();
>   }
>   return defaultBus;
> }
> Also, the setDefaultBus() method in both classes needs to be properly synchronized. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.