cxf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Ganesh (JIRA)" <j...@apache.org>
Subject [jira] Created: (CXF-389) Make org.apache.cxf.jaxws.EndpointImpl constructor generic
Date Wed, 24 Jan 2007 04:40:49 GMT
Make org.apache.cxf.jaxws.EndpointImpl constructor generic
----------------------------------------------------------

                 Key: CXF-389
                 URL: https://issues.apache.org/jira/browse/CXF-389
             Project: CXF
          Issue Type: Improvement
          Components: JAX-WS Runtime
    Affects Versions: 2.0-M1, 2.0-RC
            Reporter: Bharath Ganesh


Bharath:
Currently (in M1 release) the constructor of EndpointImpl looks like
*public EndpointImpl(Bus b, Object implementor, JaxWsServiceFactoryBean
serviceFactory).*

Instead it would be better if it takes an AbstractJaxWsServiceFactoryBean
instead of JaxWsServiceFactoryBean. This would be helpful for Provider based
endpoints to use this contructor, since JaxWsServiceFactoryBean and
ProviderServiceFactoryBean are subclasses of
AbstractJaxWsServiceFactoryBean.

Dan: 
I think that would be fine. I don't see any code specific to to
JaxWsServiceFactoryBean in the constructor. Could you create a JIRA issue
for this please?
Thanks,
- Dan


Daniel: 
Not only possible, but definitely more "correct".   The internal field that is 
set actually is an AbstractJaxWsServiceFactoryBean:
private AbstractJaxWsServiceFactoryBean serviceFactory;
.....
this.serviceFactory = serviceFactory;
Nothing in the constructor requires it to be the specific subclass.
I'll go ahead and make that change. 
Thanks!
-- 
J. Daniel Kulp


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message