From dev-return-18721-archive-asf-public=cust-asf.ponee.io@cxf.apache.org Sat Jan 20 20:11:51 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A3F1C18066D for ; Sat, 20 Jan 2018 20:11:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9351E160C38; Sat, 20 Jan 2018 19:11:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0B432160C28 for ; Sat, 20 Jan 2018 20:11:50 +0100 (CET) Received: (qmail 43069 invoked by uid 500); 20 Jan 2018 19:11:50 -0000 Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list dev@cxf.apache.org Received: (qmail 43057 invoked by uid 99); 20 Jan 2018 19:11:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 Jan 2018 19:11:49 +0000 From: GitBox To: dev@cxf.apache.org Subject: [GitHub] johnament commented on a change in pull request #369: [CXF-7610] - Adding SPI to handle customizations to the server bean. Message-ID: <151647550943.20296.15570384455438021952.gitbox@gitbox.apache.org> johnament commented on a change in pull request #369: [CXF-7610] - Adding SPI to handle customizations to the server bean. URL: https://github.com/apache/cxf/pull/369#discussion_r162790633 ########## File path: rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/ResourceUtils.java ########## @@ -902,9 +904,18 @@ public static JAXRSServerFactoryBean createApplication(Application app, bean.getProperties(true).putAll(appProps); } bean.setApplication(app); - + customize(bean); return bean; } + + private static void customize(JAXRSServerFactoryBean bean) { + ServiceLoader extensions Review comment: @reta thought about this a bit. I want to leave the method that discovers and executes the extensions here, but invoke it from the CDI extension. The reason being, if others want to leverage the `ServiceLoader` pattern, they can without having to rewrite it. @rmannibucau I'm pretty sure the whole reason this feature exists in the first place is because that CDI event pattern doesn't work properly (in this use case). BTW, does meecrowave use the CDI extension for CXF? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services