From dev-return-18674-archive-asf-public=cust-asf.ponee.io@cxf.apache.org Mon Jan 15 18:13:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 9E709180657 for ; Mon, 15 Jan 2018 18:13:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8CAB7160C31; Mon, 15 Jan 2018 17:13:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C99D4160C25 for ; Mon, 15 Jan 2018 18:13:03 +0100 (CET) Received: (qmail 85125 invoked by uid 500); 15 Jan 2018 17:13:02 -0000 Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list dev@cxf.apache.org Received: (qmail 85114 invoked by uid 99); 15 Jan 2018 17:13:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jan 2018 17:13:02 +0000 From: GitBox To: dev@cxf.apache.org Subject: [GitHub] johnament commented on a change in pull request #366: Handle ResponseExceptionMappers Message-ID: <151603638214.19643.2504799200716465632.gitbox@gitbox.apache.org> johnament commented on a change in pull request #366: Handle ResponseExceptionMappers URL: https://github.com/apache/cxf/pull/366#discussion_r161575879 ########## File path: rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/MicroProfileClientProviderFactory.java ########## @@ -91,18 +91,14 @@ protected void setProviders(boolean custom, boolean busGlobal, Object... provide public List> createResponseExceptionMapper(Message m, Class paramType) { - List> candidates = new LinkedList<>(); - - for (ProviderInfo> em : responseExceptionMappers) { - if (handleMapper(em, paramType, m, ResponseExceptionMapper.class, true)) { - candidates.add(em.getProvider()); - } - } - if (candidates.size() == 0) { + if (responseExceptionMappers.isEmpty()) { Review comment: Ah yes, forgot about the property. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services