cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rmannibucau commented on a change in pull request #369: [CXF-7610] - Adding SPI to handle customizations to the server bean.
Date Thu, 01 Jan 1970 00:00:00 GMT
rmannibucau commented on a change in pull request #369: [CXF-7610] - Adding SPI to handle customizations
to the server bean.
URL: https://github.com/apache/cxf/pull/369#discussion_r162794354
 
 

 ##########
 File path: rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/ResourceUtils.java
 ##########
 @@ -902,9 +904,18 @@ public static JAXRSServerFactoryBean createApplication(Application app,
             bean.getProperties(true).putAll(appProps);
         }
         bean.setApplication(app);
-
+        customize(bean);
         return bean;
     }
+
+    private static void customize(JAXRSServerFactoryBean bean) {
+        ServiceLoader<JAXRSServerFactoryCustomizationExtension> extensions
 
 Review comment:
   Yes meecrowave uses the extension.
   
   The fact to not use a SPI but a native cxf loading makes the feature generic IMHO. If we
dont care about it as a feature then just testing if sse jar is here (loadClass is fine) and
set the sse transportid is enough and doesnt require any SPI.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message