Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
From: GitBox <git@apache.org>
To: dev@cxf.apache.org
Subject: [GitHub] gonzalad closed pull request #26: IDP maxParameter size is set only if positive
Message-ID: <151093481782.9971.13491604294038464847.gitbox@gitbox.apache.org>
archived-at: Fri, 17 Nov 2017 16:06:59 -0000

gonzalad closed pull request #26: IDP maxParameter size is set only if positive
URL: https://github.com/apache/cxf-fediz/pull/26
 
 
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/services/idp-core/src/main/java/org/apache/cxf/fediz/service/idp/service/jpa/IdpDAOJPAImpl.java b/services/idp-core/src/main/java/org/apache/cxf/fediz/service/idp/service/jpa/IdpDAOJPAImpl.java
index 360755a7..ee5b052a 100644
--- a/services/idp-core/src/main/java/org/apache/cxf/fediz/service/idp/service/jpa/IdpDAOJPAImpl.java
+++ b/services/idp-core/src/main/java/org/apache/cxf/fediz/service/idp/service/jpa/IdpDAOJPAImpl.java
@@ -333,7 +333,10 @@ public static Idp entity2domain(IdpEntity entity, List<String> expandList) {
         idp.setRpSingleSignOutCleanupConfirmation(entity.isRpSingleSignOutCleanupConfirmation());
         idp.setAutomaticRedirectToRpAfterLogout(entity.isAutomaticRedirectToRpAfterLogout());
         idp.setDisableLogoutAddressValidation(entity.isDisableLogoutAddressValidation());
-        idp.setMaxParameterSize(entity.getMaxParameterSize());
+
+        if (entity.getMaxParameterSize() > 0) {
+            idp.setMaxParameterSize(entity.getMaxParameterSize());
+        }
 
         if (expandList != null && (expandList.contains("all") || expandList.contains("applications"))) {
             for (ApplicationEntity item : entity.getApplications()) {


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services