Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 501A7200D3C for ; Tue, 14 Nov 2017 15:09:55 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4EAAF160BF4; Tue, 14 Nov 2017 14:09:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8A3F91609EF for ; Tue, 14 Nov 2017 15:09:54 +0100 (CET) Received: (qmail 56698 invoked by uid 500); 14 Nov 2017 14:09:53 -0000 Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list dev@cxf.apache.org Received: (qmail 56687 invoked by uid 99); 14 Nov 2017 14:09:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2017 14:09:53 +0000 From: GitBox To: dev@cxf.apache.org Subject: [GitHub] johnament commented on a change in pull request #339: CXF-7544: Support @Context-based injection into proxied CDI beans Message-ID: <151066859307.19209.13253209964333303605.gitbox@gitbox.apache.org> archived-at: Tue, 14 Nov 2017 14:09:55 -0000 johnament commented on a change in pull request #339: CXF-7544: Support @Context-based injection into proxied CDI beans URL: https://github.com/apache/cxf/pull/339#discussion_r150841179 ########## File path: integration/cdi/src/main/java/org/apache/cxf/cdi/CdiClassUnwrapper.java ########## @@ -22,8 +22,18 @@ import org.apache.cxf.common.util.ClassUnwrapper; +/** + * Unwraps the CDI proxy classes into real classes. + */ class CdiClassUnwrapper implements ClassUnwrapper { - private static final Pattern PROXY_PATTERN = Pattern.compile(".+\\$\\$.+Proxy"); + /** + * Known proxy patterns for OWB and Weld: + * + * Xxx$$OwbNormalScopeProxy0 + * Xxx$Proxy$_$$_WeldClientProxy + * + */ + private static final Pattern PROXY_PATTERN = Pattern.compile(".+\\$\\$.+Proxy\\d*"); Review comment: are you sure its always digits on the end? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services