cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Beryozkin <>
Subject Re: Swagger2Feature bug caused by removal of isScan() check
Date Tue, 10 Oct 2017 16:13:24 GMT
I've introduced the property but it is set to false in 3.2.x

On 07/10/17 17:17, Sergey Beryozkin wrote:
> Hi Dennis
> Thanks very much, my fault really as I did not see a point in keeping 
> this property in 3.2.x and indeed, as you imply, all tests were/are 
> still passing, but I guess more preparation should've gone into it.
> Setting a scan to true did never work in OSGI as far as I know, may be 
> in some basic cases only, so in OSGI case, one nearly always has to set 
> it to false anyway. I recall James Carman also suggesting to disable it 
> by default. Then I also looked at

> and could not see (and still do not see) how this property, if set to 
> false, can have any effect on disabling the scan, the only thing I found 
> that the actual setScan call was still needed.
> But the problem came from the other angle :-).
> I guess the easiest way around it is to return a setScan setter to 
> 3.2.x, given that in some (I'd say - rare) cases uses depend on 
> BeanConfig's implementation, but in 3.2.x keep this value by default to 
> 'false' so that in most other cases people do not have do setScan(false).
> Cheers, Sergey
> On 07/10/17 13:47, Dennis Kieselhorst wrote:
>> Hi Taylor!
>>> This causes the subsequent code (line 196):
>>> BeanConfig beanConfig = appInfo == null
>>>      ? new BeanConfig()
>>>      : new ApplicationBeanConfig(appInfo.getProvider());
>>> …to always instantiate an ApplicationBeanConfig object. Our 
>>> production code relied on the BeanConfig’s implementation of its 
>>> classes() method to grab our ReaderListener classes annotated with 
>>> @SwaggerDefinition. Because a BeanConfig will never be instantiated 
>>> this way anymore, we would no longer be able to use our current 
>>> implementations of the ReaderListener interface.
>>> Is this a known bug, or is there a workaround that I’m missing?
>> Can you create a PR with a unittest for your scenario?
>> Unfortunately there are many ways of using Swagger2Feature and obviously
>> we missed that one.
>> Regards
>> Dennis

Sergey Beryozkin

Talend Community Coders

View raw message