Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B8007200CD8 for ; Wed, 2 Aug 2017 20:35:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B699516A1B9; Wed, 2 Aug 2017 18:35:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F35C016A1B6 for ; Wed, 2 Aug 2017 20:35:14 +0200 (CEST) Received: (qmail 71488 invoked by uid 500); 2 Aug 2017 18:35:14 -0000 Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list dev@cxf.apache.org Received: (qmail 71446 invoked by uid 99); 2 Aug 2017 18:35:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Aug 2017 18:35:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9B5C7DFF66; Wed, 2 Aug 2017 18:35:13 +0000 (UTC) From: andymc12 To: dev@cxf.apache.org Reply-To: dev@cxf.apache.org References: In-Reply-To: Subject: [GitHub] cxf issue #301: [CXF-7462] Minor improvements to OutboundSseEventImpl Content-Type: text/plain Message-Id: <20170802183513.9B5C7DFF66@git1-us-west.apache.org> Date: Wed, 2 Aug 2017 18:35:13 +0000 (UTC) archived-at: Wed, 02 Aug 2017 18:35:15 -0000 Github user andymc12 commented on the issue: https://github.com/apache/cxf/pull/301 Andriy, I went ahead with throwing IllegalArgumentExceptions when the user passes in null as either the data or type parameters. This is more consistent with the API in the `javax.ws.rs.sse.Sse` interface. If you disagree, please let me know. I'll plan to leave this PR open until tomorrow. Thanks again for the thorough review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---