cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andymc12 <...@git.apache.org>
Subject [GitHub] cxf issue #301: [CXF-7462] Minor improvements to OutboundSseEventImpl
Date Thu, 03 Aug 2017 14:21:26 GMT
Github user andymc12 commented on the issue:

    https://github.com/apache/cxf/pull/301
  
    @reta @sberyozkin I've updated the code again - here is the rough summary of changes:
    1) Default the event's _type_ to be `data.getClass()`
    2) Throw an IllegalArgumentException if `data` is null.  This is consistent with the spec's
`Sse.newEvent(null)` method.
    3) Default the event's _MediaType_ to be `MediaType.TEXT_PLAIN_TYPE` - this avoids NPEs
that I was seeing in the `OutboundSseEventBodyWriter` class.
    4) Tests for all of these cases.  
    
    I'm going on vacation tomorrow, so hopefully I can get this merged today.  Can you two
give the code one last review?  
    
    Thanks again!
    Andy


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message