cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From asoldano <...@git.apache.org>
Subject [GitHub] cxf issue #262: [CXF-7339] Fix NPE due to weak reference being GC-ed
Date Wed, 19 Apr 2017 16:22:14 GMT
Github user asoldano commented on the issue:

    https://github.com/apache/cxf/pull/262
  
    @andymc12 , actually I expected a concern about this, that's why I opened up a PR instead
of committing directly. I'm not sure we want to keep the former behavior wrt supporting null
keys. I don't think entries with null keys were actually used before, null keys happened to
be "supported" because of the internal implementation detail choice. This said I believe the
code that I fixed is not calling remove(null) on purpose, basically the change here is exposing
a bug that was there before.
    @dkulp what's your opinion on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message