cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From reta <...@git.apache.org>
Subject [GitHub] cxf pull request #247: CXF-7291: sharedPackageName for Swagger desc should i...
Date Tue, 21 Mar 2017 17:20:48 GMT
Github user reta commented on a diff in the pull request:

    https://github.com/apache/cxf/pull/247#discussion_r107218893
  
    --- Diff: core/src/main/java/org/apache/cxf/common/util/PackageUtils.java ---
    @@ -56,7 +57,9 @@ public static String getSharedPackageName(List<Class<?>>
classes) {
             List<List<String>> lParts = new ArrayList<List<String>>(classes.size());
             List<String> currentParts = new ArrayList<>();
             for (Class<?> cls : classes) {
    -            lParts.add(StringUtils.getParts(getPackageName(cls), "\\."));
    +            if (!Proxy.isProxyClass(cls)) {
    --- End diff --
    
    In this case, should we get the real class using `getProxyClass` and extract the package
from it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message