Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6EA0C200BE7 for ; Tue, 20 Dec 2016 16:31:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6D0C2160B29; Tue, 20 Dec 2016 15:31:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B3B5F160B12 for ; Tue, 20 Dec 2016 16:31:44 +0100 (CET) Received: (qmail 85402 invoked by uid 500); 20 Dec 2016 15:31:43 -0000 Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list dev@cxf.apache.org Received: (qmail 85391 invoked by uid 99); 20 Dec 2016 15:31:43 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Dec 2016 15:31:43 +0000 Received: from mail-qk0-f179.google.com (mail-qk0-f179.google.com [209.85.220.179]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 728C81A0046 for ; Tue, 20 Dec 2016 15:31:43 +0000 (UTC) Received: by mail-qk0-f179.google.com with SMTP id q68so52016612qki.1 for ; Tue, 20 Dec 2016 07:31:43 -0800 (PST) X-Gm-Message-State: AIkVDXJl2VBji1R35TN7qbM8N8wqzkDpoBzdn4nBl6bm3Rz2OlVqBpIHea/axTv4tlWguEMS1s+zri/jilmMvw== X-Received: by 10.55.179.195 with SMTP id c186mr8159906qkf.137.1482247902387; Tue, 20 Dec 2016 07:31:42 -0800 (PST) MIME-Version: 1.0 Reply-To: coheigea@apache.org Received: by 10.237.52.166 with HTTP; Tue, 20 Dec 2016 07:31:42 -0800 (PST) In-Reply-To: References: From: Colm O hEigeartaigh Date: Tue, 20 Dec 2016 15:31:42 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Small refactoring in STSTokenOutInterceptor To: "dev@cxf.apache.org" Content-Type: multipart/alternative; boundary=94eb2c0704bab0e760054418bbf2 archived-at: Tue, 20 Dec 2016 15:31:45 -0000 --94eb2c0704bab0e760054418bbf2 Content-Type: text/plain; charset=UTF-8 Hi Andrei, Please go ahead, no objections from me. Colm. On Sun, Dec 18, 2016 at 3:34 PM, Andrei Shakirin wrote: > Hi Sergei and Colm, > > I am going to make a small refactoring in STSTokenOutInterceptor. > > The idea is to move AuthMode enumeration, AuthParams class and > configureBasicSTSClient method into STSUtils and reuse them from there in > STSTokenOutInterceptor. > The AuthMode and AuthParams will be first marked as deprecated in > STSTokenOutInterceptor and removed in the next major CXF version. > > Reasons: > 1) It will be easy to reuse AuthMode, AuthParams and > configureBasicSTSClient for token validation, not only for token issuing. > 2) IMO the classes logically fit better to STSUtils > > In the future, I would like to extend AuthMode with UT_SYMMETRIC AND > KERBEROS. > > WDYT? > > Andrei. > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com --94eb2c0704bab0e760054418bbf2--