Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
From: Mark Struberg <struberg@yahoo.de.INVALID>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\))
Subject: Re: MediaType matching question
Date: Fri, 9 Dec 2016 19:47:46 +0100
References: <32DE5B4C-4388-4371-9E28-34D4F3E493DC@yahoo.de>
 <CACLE=7O_JzV0ybp4LJXYW1ktVOQxPuo1o-ggKYaok=Y2czWbuA@mail.gmail.com>
 <456020132.1100977.1481300226679@mail.yahoo.com>
 <2aa27848-59af-addf-cbcb-90f14a9f8833@gmail.com>
 <2137963384.1126751.1481303511562@mail.yahoo.com>
 <c7b35763-0034-7806-cd52-c725c3bbaa3a@gmail.com>
To: dev@cxf.apache.org
In-Reply-To: <c7b35763-0034-7806-cd52-c725c3bbaa3a@gmail.com>
Message-Id: <1C364EC7-E0B0-4AF9-9EF5-427B126EB445@yahoo.de>
archived-at: Fri, 09 Dec 2016 18:48:09 -0000

Yes it does, but it doesn't seem to be a CXF bug. The bug is in the RI =
API (and in geronimo we ported the logic 1:1).
I'm also not sure if this is a 'bug' in the API or in the spec.=20

=46rom a user pov it seems counter intuitive at least.

LieGrue,
strub

> Am 09.12.2016 um 18:22 schrieb Sergey Beryozkin =
<sberyozkin@gmail.com>:
>=20
> Hmm,
> are you saying CXF will match "*/*+json" against =
application/octet-stream ? I have to sign off right now, but I honestly =
doubt it, I'll check later on.
>=20
>=20
> Thanks, Sergey
>=20
>=20
>=20
> On 09/12/16 17:11, Mark Struberg wrote:
>>> Do you expect a "*/*+json" match the application/octet-stream ?
>>=20
>>=20
>> No, I did not expect that. But that's exactly how the code of =
MediaType#isCompatible behaves currently :(
>>=20
>>=20
>>=20
>> LieGrue,
>> strub
>>=20
>>=20
>>=20
>>=20
>>> On Friday, 9 December 2016, 17:24, Sergey Beryozkin =
<sberyozkin@gmail.com> wrote:
>>>> Hi Mark, welcome,
>>>=20
>>> Do you expect a "*/*+json" match the application/octet-stream ?
>>> And how is the method parameter accepting a multipart payload is =
typed,
>>> as InputStream ?
>>>=20
>>> As a side note with WebClient you can use a more dedicated =
Attachment
>>> code but on the server side, if you need to stay 100% compliant, =
then
>>> yes, you;d need to read from InputStream and parse the payload =
manually
>>> - CXF MultipartProvider will not touch it unless it is annotated =
with a
>>> CXF specific annotation
>>>=20
>>> Cheers, Sergey
>>>=20
>>>=20
>>> On 09/12/16 16:17, Mark Struberg wrote:
>>>> While debugging through this didn't get used as far as I remember.
>>>>=20
>>>> Maybe MultipartProvider uses an alternative path to detect the =
handlers?
>>>>=20
>>>> LieGrue,
>>>> strub
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>>> On Friday, 9 December 2016, 17:15, Romain Manni-Bucau
>>> <rmannibucau@gmail.com> wrote:
>>>>>> Hey Mark,
>>>>>=20
>>>>> have a look
>>>>> to
>>> =
org.apache.cxf.jaxrs.provider.ProviderFactory.MessageBodyWriterComparator
>>>>> (and the reader companion) maybe. Got aligned in cxf "jaxrs
>>> 2" for
>>>>> spec
>>>>> alignment
>>>>>=20
>>>>>=20
>>>>> Romain Manni-Bucau
>>>>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>>>>> <https://blog-rmannibucau.rhcloud.com> | Old Blog
>>>>> <http://rmannibucau.wordpress.com> | Github
>>>>> <https://github.com/rmannibucau> |
>>>>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE
>>> Factory
>>>>> <https://javaeefactory-rmannibucau.rhcloud.com>
>>>>>=20
>>>>>=20
>>>>> 2016-12-09 17:10 GMT+01:00 Mark Struberg
>>> <struberg@yahoo.de.invalid>:
>>>>>=20
>>>>>>  good evening!
>>>>>>=20
>>>>>>  My first post to CXF, so I excuse if I ask something obvious ;)
>>>>>>=20
>>>>>>  We have the following code over in Apache OpenWebBeans /
>>> Meecrowave:
>>>>>>=20
>>>>>>  @Produces({
>>>>>>          "application/json", "*/json",
>>>>>>          "*/*+json", "*/x-json",
>>>>>>          "*/javascript", "*/x-javascript"
>>>>>>  })
>>>>>>  @Consumes({
>>>>>>          "application/json", "*/json",
>>>>>>          "*/*+json", "*/x-json",
>>>>>>          "*/javascript", "*/x-javascript"
>>>>>>  })
>>>>>>  public static class ConfiguredJsonbJaxrsProvider<T> extends
>>>>>>  JsonbJaxrsProvider<T> {
>>>>>>=20
>>>>>>  I tried to use the CXF WebClient to send a multipart form with a
>>> file
>>>>>>  attachment. MediaType is application/octet-stream.
>>>>>>  Sadly I always triggered our Johnzon JSONB provider
>>> (johnzon.apache.org).
>>>>>>=20
>>>>>>  The reason is that */json seems to match ANY other MediaType,
>>> regardless
>>>>>>  of the subtype. Is this intended?
>>>>>>  The code I found during debugging is the following in
>>> geronimo-jaxrs_2.0
>>>>>>  MediaType:
>>>>>>=20
>>>>>>  public boolean isCompatible(MediaType other) {
>>>>>>      return other !=3D null &&
>>> (type.equals(MEDIA_TYPE_WILDCARD) ||
>>>>>>  other.type.equals(MEDIA_TYPE_WILDCARD) ||
>>>>>>          (type.equalsIgnoreCase(other.type) &&
>>>>> (subtype.equals(MEDIA_TYPE_WILDCARD)
>>>>>>  || other.subtype.equals(MEDIA_TYPE_WILDCARD))) ||
>>>>>>          (type.equalsIgnoreCase(other.type) &&
>>>>>>  this.subtype.equalsIgnoreCase(other.subtype)));
>>>>>>  }
>>>>>>=20
>>>>>>=20
>>>>>>  I'm geronimo PMC myself so I can even fix it. But would need
>>> some
>>>>> feedback
>>>>>>  how it should behave.
>>>>>>  https://svn.apache.org/repos/asf/geronimo/specs/trunk/
>>>>>>  geronimo-jaxrs_2.0_spec/
>>>>>>=20
>>>>>>  I did a quick look at the RI and now I'm even more confused:
>>>>>>=20
>>>>>>      public boolean isCompatible(MediaType other) {
>>>>>>          return other !=3D null && // return false if other
>>> is null,
>>>>> else
>>>>>>                  (type.equals(MEDIA_TYPE_WILDCARD) ||
>>>>>>  other.type.equals(MEDIA_TYPE_WILDCARD) || // both are wildcard
>>> types, or
>>>>>>                          (type.equalsIgnoreCase(other.type)
>>> &&
>>>>>>  (subtype.equals(MEDIA_TYPE_WILDCARD)
>>>>>>                                  ||
>>>>> other.subtype.equals(MEDIA_TYPE_WILDCARD)))
>>>>>>  || // same types, wildcard sub-types, or
>>>>>>                          (type.equalsIgnoreCase(other.type)
>>> &&
>>>>>>  this.subtype.equalsIgnoreCase(other.subtype))); // same types
>>> &
>>>>> sub-types
>>>>>>      }
>>>>>>=20
>>>>>>  It says "both are wildcard types" but the code is
>>> actually ONE of
>>>>> them is
>>>>>>  a wildcard type, isn't?
>>>>>>   (type.equals(MEDIA_TYPE_WILDCARD) ||
>>>>> other.type.equals(MEDIA_TYPE_WILDCARD)
>>>>>>  || // both are wildcard types, or
>>>>>>=20
>>>>>>=20
>>>>>>  Any hints are highly welcome, my head is already hurting...
>>>>>>=20
>>>>>>  What are the actual rules for matching MediaTypes? What does the
>>> spec
>>>>>>  define?
>>>>>>=20
>>>>>>  txs and LieGrue,
>>>>>>  strub
>>>>>>=20
>>>>>>=20
>>>>>>=20
>>>>>>=20
>>>>>=20
>>>=20
>>>=20
>>> --
>>>=20
>=20
>=20
> --=20
> Sergey Beryozkin
>=20
> Talend Community Coders
> http://coders.talend.com/