cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmannibucau <...@git.apache.org>
Subject [GitHub] cxf pull request #:
Date Wed, 16 Nov 2016 11:21:55 GMT
Github user rmannibucau commented on the pull request:

    https://github.com/apache/cxf/commit/13fa5dc1ffebe4e63a27f17528598925af04d570#commitcomment-19843557
  
    In integration/cdi/src/main/java/org/apache/cxf/cdi/CdiResourceProvider.java:
    In integration/cdi/src/main/java/org/apache/cxf/cdi/CdiResourceProvider.java on line 54:
    shouldnt it be called only for not normal scoped beans? (we can know it in the constructor
using beanManager.isNormalScope(bean.getScope()) to avoid to request it each time there. ALso
for normal scoped bean we can cache the instance and makes the getInstance/release very fast:
https://github.com/apache/tomee/blob/master/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CdiResourceProvider.java#L263
vs https://github.com/apache/tomee/blob/master/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CdiResourceProvider.java#L281
typically


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message