Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Subject: Re: Failing rs-sse system tests
To: Andriy Redko <drreta@gmail.com>
References: <CAB8XdGB=33Rhs06=BM5JyQ80_Nn+BTVtshPGSjjD=Ex7VYGUNQ@mail.gmail.com>
 <534164612.20160922213324@gmail.com>
 <CAB8XdGCsSEcQem8EvhkjkaF1C8aYBe3stnuq_qxY-bVTRLH6dg@mail.gmail.com>
 <794eadb3-f198-6d94-45ce-55e5626c6b1f@gmail.com>
 <1536994374.20160923062207@gmail.com>
Cc: dev@cxf.apache.org
From: Sergey Beryozkin <sberyozkin@gmail.com>
Message-ID: <4262c607-f698-bb9c-0f6a-2fd72d587330@gmail.com>
Date: Fri, 23 Sep 2016 11:30:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1536994374.20160923062207@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
archived-at: Fri, 23 Sep 2016 10:30:23 -0000

Hi Andriy

Interesting. I wonder if Jetty can be tuned somehow so that as far as 
ATM is concerned the same code path is used there irrespectively of 
whether it is Jetty or Tomcat - given that with Tomcat the tests pass

Thanks, Sergey
On 23/09/16 11:22, Andriy Redko wrote:
> Hey Sergey,
>
> Yeah, I have gotten all them green on my machine (always failing before) and
> thought they are fixed now, will look more today. It is definitely Jetty
> specific, I know why Jetty fails but I have not found a way to workaround
> that (it is deeply inside Atm). I will spend more time today and in worst
> case just please comment them out if it something blocking you guys.
>
> Thanks!
>
> Best Regards,
>     Andriy Redko
>
> SB> Looks like it is a test (or SSE impl) state issue,
> SB> Andriy, FYI, if I run complete JettyEmbeddedTest then I see:
>
>
> SB> testBooksStreamIsReturnedFromLastEventId - OK
> SB> testBooksAreReturned - Fail
>
> SB> If I only run
>
> SB> JettyEmbeddedTest.testBooksAreReturned
>
> SB> then it is green.
>
> SB> Same tests run with Tomcat though (I wonder by the way if CXF should
> SB> have an http-tomcat transport too).
> SB> So may be it is Jetty specific ?
>
> SB> Cheers, Sergey
>
> SB> On 23/09/16 10:14, Colm O hEigeartaigh wrote:
>>> No apologies necessary Andriy! We all inadvertently break tests.
>
>>> Both tests are still failing for me however:
>
>>> Failed tests:
>
>>> JettyEmbeddedTest>AbstractSseTest.testBooksAreReturned:62->Assert.assertEquals:631->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88
>>> expected:<200> but was:<500>
>
>>> JettyWarTest>AbstractSseTest.testBooksAreReturned:62->Assert.assertEquals:631->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88
>>> expected:<200> but was:<500>
>
>>> My Java version is "1.8.0_101" on linux if that helps.
>
>>> Colm.
>
>>> On Fri, Sep 23, 2016 at 2:33 AM, Andriy Redko <drreta@gmail.com> wrote:
>
>>>> Hey Colm,
>
>>>> My bad, worked on a solution but it took awhile. The fix was finally
>>>> committed a few
>>>> minutes ago, should be OK from now on. Please accept my apologies.
>
>>>> Best Regards,
>>>>     Andriy Redko
>
>>>> COh> The following tests are failing for me on the master branch:
>
>>>> COh> Failed tests:
>
>>>> JettyEmbeddedTest>>AbstractSseTest.testBooksAreReturned:73->
>>>> Assert.assertEquals:631->Assert.assertEquals:645->
>>>> Assert.failNotEquals:834->Assert.fail:88
>>>> COh> expected:<200> but was:<500>
>
>>>> JettyWarTest>>AbstractSseTest.testBooksAreReturned:73->
>>>> Assert.assertEquals:631->Assert.assertEquals:645->
>>>> Assert.failNotEquals:834->Assert.fail:88
>>>> COh> expected:<200> but was:<500>
>>>> COh> Tests in error:
>>>> COh>   TomcatEmbeddedTest>AbstractSseTest.testBooksStreamIsBroadcasted:101
>>>> »
>>>> COh> ResponseProcessing
>
>
>
>
>
>
>
>
>
>


-- 
Sergey Beryozkin

Talend Community Coders
http://coders.talend.com/