cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Schneider <ch...@die-schneider.net>
Subject Re: Coding style
Date Wed, 10 Aug 2016 10:11:17 GMT
+1 to refactor

Christian

On 10.08.2016 12:09, Behrang Saeedzadeh wrote:
> Hi,
>
> I have noticed some test cases extend Assert (e.g. JwkUtilsTest
> <https://github.com/apache/cxf/blob/e6ce20a8fb434abb5ff34f769e63ac1c71f919b0/rt/rs/security/jose-parent/jose/src/test/java/org/apache/cxf/rs/security/jose/jwk/JwkUtilsTest.java>)
> while some test cases don't.
>
> I assume the extending Assert is a pre Java-5 style as back then we didn't
> have static imports.
>
> Any objections to refactor these test cases and make them extend nothing
> (well, Object) and instead use static imports?
>
> Best regards,
> Behrang Saeedzadeh
>


-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
http://www.talend.com


Mime
View raw message