cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cschneider <...@git.apache.org>
Subject [GitHub] cxf pull request: 3.1.x fixes - CXF-6454
Date Fri, 22 Apr 2016 09:19:16 GMT
Github user cschneider commented on the pull request:

    https://github.com/apache/cxf/pull/132#issuecomment-213348723
  
    I do not yet see a good case for limiting the number of retries as the cxf endpoint or
client would be unusable at this point. Can you elaborate how the max retries would help in
practice? Especially what would happen after the retries are stopped. Btw. This might be something
we could discuss on IRC. I am always in the [channel #apache-cxf](https://cxf.apache.org/mailing-lists.html).
    
    1. Not sure I understand this case. Can you elaborate the steps that would happen?
    2. I think the retry thread should run as long as the CXF endpoint is active. My intention
is that you can simply call shutdown on the Destination which ends the retry thread. Interrupting
a thread is not such a good idea to achieve this.
    3. I agree to have the sleep there. I wrongly thought that this code would also be run
on the first connect.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message