cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cschneider <...@git.apache.org>
Subject [GitHub] cxf pull request: - implemented AutoCloseable Client
Date Tue, 19 Apr 2016 14:52:07 GMT
Github user cschneider commented on the pull request:

    https://github.com/apache/cxf/pull/124#issuecomment-211961022
  
    This code does not seem to build. I got somee checkstyle errors.
    I also think setting the classloader on the bus is not correct as the bus may be for a
complete
    bundle. So setting it when a DynamicClient is created and removing it when it is removed
does not seem to be valid for all cases.
    
    Pelase also try to not reformat the code in commits that also change the logic as this
makes it a lot harder to review.
    
    Ideally you should create one branch / pull request per jira issue and make sure the code
builds on your machine using mvn clean install.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message