Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
From: willuhn <git@git.apache.org>
To: dev@cxf.apache.org
Reply-To: dev@cxf.apache.org
Message-ID: <git-pr-97-cxf@git.apache.org>
Subject: [GitHub] cxf pull request: Compatibility to Jetty 9.3+
Content-Type: text/plain
Date: Thu, 22 Oct 2015 10:20:50 +0000 (UTC)

GitHub user willuhn opened a pull request:

    https://github.com/apache/cxf/pull/97

    Compatibility to Jetty 9.3+

    Jetty 9.3 contains a tiny (but fatal) change in SslConnectionFactory:
    
      public SslConnectionFactory(@Name("sslContextFactory") SslContextFactory factory, @Name("next") String nextProtocol)
      {
        -        super("SSL-"+nextProtocol);
       +        super("SSL");
    
    See:
    http://git.eclipse.org/c/jetty/org.eclipse.jetty.project.git/tree/jetty-server/src/main/java/org/eclipse/jetty/server/SslConnectionFactory.java
    http://git.eclipse.org/c/jetty/org.eclipse.jetty.project.git/commit/jetty-server/src/main/java/org/eclipse/jetty/server/SslConnectionFactory.java?id=287e86b7aa787c9836fccbe2816dd08b4b6c599e
    
    The protocol is now named "SSL" (was "SSL-HTTP" before).
    
    If you still use "SSL-HTTP" as default protocol name, the "doStart" of the jetty connector will fail in 9.3+:
    
    (from org.eclipse.jetty.server.AbstractConnector):
    
      protected void doStart() throws Exception
      {
            _defaultConnectionFactory = getConnectionFactory(_defaultProtocol);
            if(_defaultConnectionFactory==null)
                throw new IllegalStateException("No protocol factory for default protocol: "+_defaultProtocol);
        ...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/willuhn/cxf patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #97
    
----
commit 5669ebf9b7f3ed1293458d5f3ff3e3e84fde21ef
Author: Olaf Willuhn <github@willuhn.de>
Date:   2015-10-22T10:20:31Z

    Compatibility to Jetty 9.3+
    
    Jetty 9.3 contains a tiny (but fatal) change in SslConnectionFactory:
    
      public SslConnectionFactory(@Name("sslContextFactory") SslContextFactory factory, @Name("next") String nextProtocol)
      {
        -        super("SSL-"+nextProtocol);
       +        super("SSL");
    
    See:
    http://git.eclipse.org/c/jetty/org.eclipse.jetty.project.git/tree/jetty-server/src/main/java/org/eclipse/jetty/server/SslConnectionFactory.java
    http://git.eclipse.org/c/jetty/org.eclipse.jetty.project.git/commit/jetty-server/src/main/java/org/eclipse/jetty/server/SslConnectionFactory.java?id=287e86b7aa787c9836fccbe2816dd08b4b6c599e
    
    The protocol is now named "SSL" (was "SSL-HTTP" before).
    
    If you still use "SSL-HTTP" as default protocol name, the "doStart" of the jetty connector will fail in 9.3+:
    
    (from org.eclipse.jetty.server.AbstractConnector):
    
      protected void doStart() throws Exception
      {
            _defaultConnectionFactory = getConnectionFactory(_defaultProtocol);
            if(_defaultConnectionFactory==null)
                throw new IllegalStateException("No protocol factory for default protocol: "+_defaultProtocol);
        ...

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---