cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From skjolber <...@git.apache.org>
Subject [GitHub] cxf pull request: [CXF-6423] PrettyLoggingFilter tests and improve...
Date Sat, 30 May 2015 17:12:48 GMT
Github user skjolber commented on the pull request:

    https://github.com/apache/cxf/pull/75#issuecomment-107067157
  
    So for logging, why would it be logical to try to repair trunkated (or invalid xml)?
    
    The primary goal must be to log something which correctly represents the payload content.
And does that whether the content is good or bad xml, trunkated or not.
    
    Consider this valid xml string:
    
    ```xml
    <a><b><c></c></b></a>
    ```
    
    if it is trunkated to 
    
    ```xml
    <a><b>
    ```
    
    then the current approach would give you
    
    ```xml
    <a><b></b></a>
    ```
    
    as the closing tags are added. This is not only a string which is longer than the limit,
it might give the impression that there is no c element. This is clearly a good way to create
misunderstandings. 
    
    Another use-case: This one shows that inserting an 'content trunkated' message and then
adding end tags is not a good idea either
    
    Consider this invalid xml string:
    
    ```xml
    <a><b><c></c></a>
    ```
    
    if it is trunkated to 
    
    ```xml
    <a><b><c></c>
    ```
    
    then the current approach would give you
    
    ```xml
    <a><b><c></c></b></a>
    ```
    
    which is valid xml. And so tracking the problem by looking at the logged xml would be
quit difficult. So if we did
    
    ```xml
    <a><b><c></c>[content trunkated]</b></a>
    ```
    we would still have the same problem.
    
    Certainly I can add some more test cases and test documentation, if you prefer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message