cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From escabe <...@git.apache.org>
Subject [GitHub] cxf pull request: Fix for [CXF-6161]
Date Tue, 23 Dec 2014 13:11:35 GMT
Github user escabe commented on the pull request:

    https://github.com/apache/cxf/pull/43#issuecomment-67949395
  
    Ok, I could look into that. Before I do so however, do you have a preferred
    way of checking for valid file names in this project? Is doing a
    File.createNewFile() inside TRY-CATCH acceptable?
    
    On Thu, Dec 18, 2014 at 12:00 AM, Daniel Kulp <notifications@github.com>
    wrote:
    
    > If the file is a valid name, I would greatly prefer to keep the name.
    >
    > Also, one of the tests fails due to this. testClientJar fails due to:
    >
    >     assertTrue("hello_world_messages.wsdl is expected",
    >                  jarEntries.contains("hello_world_messages.wsdl"));
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cxf/pull/43#issuecomment-67413089>.
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message