Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Received-SPF: pass (nike.apache.org: domain of ashakirin@talend.com designates
 74.201.97.201 as permitted sender)
From: Andrei Shakirin <ashakirin@talend.com>
To: "dev@cxf.apache.org" <dev@cxf.apache.org>
CC: Daniel Kulp <dkulp@apache.org>
Subject: RE: Extended support for wsdl11external WS-PolicyAttachments
 references
Thread-Topic: Extended support for wsdl11external WS-PolicyAttachments
 references
Thread-Index: Ac9VZBEL40Lws9UOTCq6UqS/cfrh0QAapOKAAz4S4FA=
Date: Mon, 28 Apr 2014 10:16:45 +0000
Message-ID: <D225CD69196F3F4A9F4174B2FCA06F8811EC8640@S10BE002.SH10.lan>
References: <D225CD69196F3F4A9F4174B2FCA06F8811EB37B2@S10BE002.SH10.lan>
 <DBA5C30F-783D-4726-93A4-7C8EA4ABAC51@apache.org>
In-Reply-To: <DBA5C30F-783D-4726-93A4-7C8EA4ABAC51@apache.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi Dan,

URIDomainExpressionBuilder [1] was added to support all WSDL11 domain expre=
ssions accordingly spec [2] (excluding wsdl11.extension(namespace,identifie=
r)).
I am thinking about registration of this builder as default bus extension (=
the same way as EndpointReferenceDomainExpressionBuilder):
- from one side default registration is comfortable for users applying WSDL=
11 expressions in external attachments, this will work just out of the box.
- from other side, if user would like to register own domain expression (li=
ke in one security integration test [3]), it will be very difficult to repl=
ace default builder.=20

The problem is that SpringConfiguredBeanLocator used in DomainExpressionBui=
lderRegistry loads Spring beans on first step and then checks for Bus exten=
sions (using ExtensionManager). Beans specified in custom configuration wil=
l be overwritten by registered bus extension.
If client or service is created using spring configuration, it is not trivi=
al to replace default DomainExpressionBuilder (it is possible with Extensio=
nManagerImpl internal methods, but not convenient).

I see following options:
(a) Leave the code as is and document that user have to register URIDomainE=
xpressionBuilder as bus extension or as a bean to use WSDL11 expressions.
(b) Change initialization order in SpringConfiguredBeanLocator to give spri=
ng beans higher priority as bus extensions (this can have side effects)
(c) Introduce convenient mechanism to replace/remove registered bus extensi=
ons or control behaviour of ConfiguredBeanLocator.
=20
What is your opinion? May be I am missing something and option (c) is alrea=
dy available?

Regards,
Andrei.

[1] https://fisheye6.atlassian.com/changelog/cxf?cs=3Da4ea197c50c99d0c02d92=
26484c3ee0f8fa63b05 =20
[2] http://www.w3.org/TR/2007/NOTE-wsdl11elementidentifiers-20070720/=20
[3] https://fisheye6.atlassian.com/browse/cxf/systests/ws-security/src/test=
/java/org/apache/cxf/systest/ws/policy/UriDomainExpression.java=20

> -----Original Message-----
> From: Daniel Kulp [mailto:dkulp@apache.org]
> Sent: Freitag, 11. April 2014 19:40
> To: dev@cxf.apache.org; Andrei Shakirin
> Subject: Re: Extended support for wsdl11external WS-PolicyAttachments
> references
>=20
>=20
> No objections here.   I think we just implemented the few basic places to=
 meet
> whatever test case we were shooting for with the old Microsoft interopera=
bility
> tests and didn't go much further.
>=20
> Dan
>=20
>=20
> On Apr 11, 2014, at 5:44 AM, Andrei Shakirin <ashakirin@talend.com> wrote=
:
>=20
> > Hi,
> >
> > Currently CXF supports only limited set of references for external WS-
> PolicyAttachments (wsa:EndpointReferenceType):
> >
> > <attachments xmlns:wsp=3D"http://www.w3.org/ns/ws-policy"
> xmlns:test=3D"http://x.y.z/Assertions">
> >    <wsp:PolicyAttachment>
> >        <wsp:AppliesTo>
> >            <wsa:EndpointReferenceType
> xmlns:wsa=3D"http://www.w3.org/2005/08/addressing">
> >                <wsa:Address>http://x.y.z/GreeterPort</wsa:Address>
> >            </wsa:EndpointReferenceType>
> >        </wsp:AppliesTo>
> >        <wsp:Policy>
> >           <test:A>A</test:A>
> >        </wsp:Policy>
> >    </wsp:PolicyAttachment>
> > </attachments>
> >
> > I propose to extend that to support at least some URI Domain Expression=
 for
> wsdl11:
> > wsdl11.definitions()
> > wsdl11.service(service)
> > wsdl11.binding(binding)
> > wsdl11.bindingOperation(binding/operation)
> > wsdl11.bindingOperation.input(binding/operation)
> > wsdl11.bindingOperation.output(binding/operation)
> > wsdl11.bindingOperation.fault(binding/operation/fault)
> >
> > I see that some work was started in cxf-rt-ws-policy
> Wsdl11XPointerDomainExpression class, but it seems that is not complete.
> > Partly it is also implemented in systests
> > org.apache.cxf.systest.ws.policy.UriDomainExpression and
> > org.apache.cxf.systest.ws.policy.UriDomainExpressionBuilder
> >
> > I would create Jira and add support for wsdl11 references.
> > Any suggestions / objections?
> >
> > Regards,
> > Andrei.
> >
>=20
> --
> Daniel Kulp
> dkulp@apache.org - http://dankulp.com/blog Talend Community Coder -
> http://coders.talend.com