Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Received-SPF: pass (athena.apache.org: local policy)
From: Beucher Thierry <thierry.beucher@worldline.com>
To: "dev@cxf.apache.org" <dev@cxf.apache.org>
Date: Thu, 5 Sep 2013 11:22:01 +0200
Subject: RE: FEDIZ-15 patch (Support the publish of the WS-Federation
 Metadata document)
Thread-Topic: FEDIZ-15 patch (Support the publish of the WS-Federation
 Metadata document)
Thread-Index: Ac6pgZVCyM4A2nbbQBSNOMB22GJDBgAJkXupABxHApA=
Message-ID: 
 <DFE323F76BAF2145B84FA4E3F09930DC2760AFAFED@FRVDX100.fr01.awl.atosorigin.net>
References: 
 <DFE323F76BAF2145B84FA4E3F09930DC2760AFAF5A@FRVDX100.fr01.awl.atosorigin.net>
 <79AB4452999C844D9920E036353327311172B574@S10BE002.SH10.lan>
In-Reply-To: <79AB4452999C844D9920E036353327311172B574@S10BE002.SH10.lan>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
acceptlanguage: fr-FR, en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi Oli,

"UTF-8" in OutputStreamWriter constructor only seems enough ....

Writer streamWriter =3D new OutputStreamWriter(bout, "UTF-8");
 XMLStreamWriter writer =3D XML_OUTPUT_FACTORY.createXMLStreamWriter(stream=
Writer);
...
writer.writeStartDocument();

Thanks


-----Message d'origine-----
De : Oliver Wulff [mailto:owulff@talend.com]
Envoy=E9 : mercredi 4 septembre 2013 21:52
=C0 : dev@cxf.apache.org
Objet : RE: FEDIZ-15 patch (Support the publish of the WS-Federation Metada=
ta document)


Hi Thierry

Thanks for spotting that. I think I have to update that during the creation=
 of the OutputStreamWriter as well:

Writer streamWriter =3D new OutputStreamWriter(bout, "UTF-8"); XMLStreamWri=
ter writer =3D XML_OUTPUT_FACTORY.createXMLStreamWriter(streamWriter);
...
writer.writeStartDocument("UTF-8", "1.0");

You agree?

Thanks
Oli


------

Oliver Wulff

Blog: http://owulff.blogspot.com
Solution Architect
http://coders.talend.com

Talend Application Integration Division http://www.talend.com

________________________________________
From: Beucher Thierry [thierry.beucher@worldline.com]
Sent: 04 September 2013 17:36
To: dev@cxf.apache.org
Subject: FEDIZ-15 patch (Support the publish of the WS-Federation Metadata =
document)

HI Oli,

I am currently testing your FEDIZ-15 patch and it fails in unit tests of fe=
diz-idp : an issue related to file encoding IBM1252 not supported is raised=
 during writing of metadatas (at document signature phase) ...

Running org.apache.cxf.fediz.service.idp.util.MetadataWriterTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 42.943 sec =
<<< FAILURE!
testWriteIDPMetadata(org.apache.cxf.fediz.service.idp.util.MetadataWriterTe=
st)  Time elapsed: 39.16 sec  <<< ERROR!
java.lang.RuntimeException: Error creating service metadata information: IB=
M1252
       at org.apache.cxf.fediz.service.idp.util.MetadataWriter.getMetaData(=
MetadataWriter.java:209)
       at org.apache.cxf.fediz.service.idp.util.MetadataWriterTest.testWrit=
eIDPMetadata(MetadataWriterTest.java:52)

below the metadatas file to be signed :

<?xml version=3D'1.0' encoding=3D'IBM1252'?> <EntityDescriptor ID=3D"_96E3E=
566F42872B96B13783064585181" entityID=3D"https://localhost:8443/fediz-idp/f=
ederation" xmlns:fed=3D"http://docs.oasis-open.org/wsfed/federation/200706"=
 xmlns:wsa=3D"http://www.w3.org/2005/08/addressing" xmlns:auth=3D"http://do=
cs.oasis-open.org/wsfed/federation/200706" xmlns:xsi=3D"http://www.w3.org/2=
001/XMLSchema-instance">
  <fed:RoleDescriptor xsi:type=3D"fed:SecurityTokenServiceType" protocolSup=
portEnumeration=3D"http://docs.oasis-open.org/wsfed/federation/200706" Serv=
iceDescription=3D"IDP of Realm A" ServiceDisplayName=3D"REALM A">
    <KeyDescriptor use=3D"signing">
      <KeyInfo>
        <X509Data>
          <X509Certificate>MIICwTCCAamgAwIBAgIEFKo9KjANBgkqhkiG9w0BAQsFADAR=
MQ8wDQYDVQQDEwZSRUFMTUEwHhcNMTMwOTAzMjAyMjMxWhcNMjMwNzEzMjAyMjMxWjARMQ8wDQY=
DVQQDEwZSRUFMTUEwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCnmQKgcHaFmTG/rM=
zlSP1DDVUn1AIVlUo2eBNBaOloKvyXrYT6zwd+mno1Skj9EQMntx9LvK6xLiquLvuKP0XGeWHhJ=
wgG4dBB1QQ71hosrWIaClLQrNuV8d8pztSkPfVrL5SdmlqDUAlC598rGhU7ttXPKp2FF8set2QI=
DSFZrRURpeAoh7aCdlySrJGBQsTGTvb4N6yF8yoxKcVBIBb62q4xS1qU10Oa+iYig3+b+vNwSzc=
N5RE9Etw+nQ8q8soiwfGcVLmWjv1oDuLrx1BOqL2zXxmISlJgv2/cC3DVnPb6IOmHaEklLbod7N=
q0JgD0L27s4Js+ccXtkoBcQtRxAgMBAAGjITAfMB0GA1UdDgQWBBSSn4p1eScqsNyywCH37ipMd=
ZNykzANBgkqhkiG9w0BAQsFAAOCAQEAnkmNaVR3lXJWh4nOvNvzXz6vBSMbm/K4khu8mRtUWHik=
bwZE72ZLCD2Bv69YhNsaAZmtH02CERUXZTbh8YXfZ0VnMh9ieTKHWpNGDOBdvfsd8jSLd4svIrP=
2vfMciS0px0Q87W4jntiQovhPuTEeOOanaG8R2eaROTONRsTQxWWGep5FqhH6Of2hL7kwEjFyLD=
E/NIMHHeURlxmbwwMbnJoA8/wVOZnGOCkmnKs96DXHD+MBCboD+2UMl76GONiksAsD+LjiqZwZe=
WsZCP+NDPEjXOv/7MzpiCSMLLk+AWzQAZDqpDwjys1YXREbVVFVlS+3Sob0hd0SJr/hsHl9Hw=
=3D=3D
          </X509Certificate>
        </X509Data>
      </KeyInfo>
    </KeyDescriptor>
    <fed:SecurityTokenServiceEndpoint>
      <wsa:EndpointReference>
        <wsa:Address>https://localhost:0/fediz-idp-sts/REALMA
        </wsa:Address>
      </wsa:EndpointReference>
    </fed:SecurityTokenServiceEndpoint>
    <fed:PassiveRequestorEndpoint>
      <wsa:EndpointReference>
        <wsa:Address>https://localhost:8443/fediz-idp/federation
        </wsa:Address>
      </wsa:EndpointReference>
    </fed:PassiveRequestorEndpoint>
  </fed:RoleDescriptor>
</EntityDescriptor>


A fix in MetadataWriter at line #96 solves it :

            writer.writeStartDocument("UTF-8","1.0");

Does it make sense to take care of various encodings ?
Strangely I didn't encountered the same issue for MetadataWriter on project=
 'core' side ....

Thanks


________________________________

Ce message et les pi?ces jointes sont confidentiels et r?serv?s ? l'usage e=
xclusif de ses destinataires. Il peut ?galement ?tre prot?g? par le secret =
professionnel. Si vous recevez ce message par erreur, merci d'en avertir im=
m?diatement l'exp?diteur et de le d?truire. L'int?grit? du message ne pouva=
nt ?tre assur?e sur Internet, la responsabilit? de Worldline ne pourra ?tre=
 recherch?e quant au contenu de ce message. Bien que les meilleurs efforts =
soient faits pour maintenir cette transmission exempte de tout virus, l'exp=
?diteur ne donne aucune garantie ? cet ?gard et sa responsabilit? ne saurai=
t ?tre recherch?e pour tout dommage r?sultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely=
 for the addressee; it may also be privileged. If you receive this e-mail i=
n error, please notify the sender immediately and destroy it. As its integr=
ity cannot be secured on the Internet, the Worldline liability cannot be tr=
iggered for the message content. Although the sender endeavours to maintain=
 a computer virus-free network, the sender does not warrant that this trans=
mission is virus-free and will not be liable for any damages resulting from=
 any virus transmitted.


Ce message et les pi=E8ces jointes sont confidentiels et r=E9serv=E9s =E0 l=
'usage exclusif de ses destinataires. Il peut =E9galement =EAtre prot=E9g=
=E9 par le secret professionnel. Si vous recevez ce message par erreur, mer=
ci d'en avertir imm=E9diatement l'exp=E9diteur et de le d=E9truire. L'int=
=E9grit=E9 du message ne pouvant =EAtre assur=E9e sur Internet, la responsa=
bilit=E9 de Worldline ne pourra =EAtre recherch=E9e quant au contenu de ce =
message. Bien que les meilleurs efforts soient faits pour maintenir cette t=
ransmission exempte de tout virus, l'exp=E9diteur ne donne aucune garantie =
=E0 cet =E9gard et sa responsabilit=E9 ne saurait =EAtre recherch=E9e pour =
tout dommage r=E9sultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely=
 for the addressee; it may also be privileged. If you receive this e-mail i=
n error, please notify the sender immediately and destroy it. As its integr=
ity cannot be secured on the Internet, the Worldline liability cannot be tr=
iggered for the message content. Although the sender endeavours to maintain=
 a computer virus-free network, the sender does not warrant that this trans=
mission is virus-free and will not be liable for any damages resulting from=
 any virus transmitted.