Return-Path: 
 <dev-return-13964-apmail-cxf-dev-archive=cxf.apache.org@cxf.apache.org>
X-Original-To: apmail-cxf-dev-archive@www.apache.org
Delivered-To: apmail-cxf-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 618D6103FF
	for <apmail-cxf-dev-archive@www.apache.org>;
 Mon,  9 Sep 2013 16:13:17 +0000 (UTC)
Received: (qmail 76990 invoked by uid 500); 9 Sep 2013 16:13:16 -0000
Delivered-To: apmail-cxf-dev-archive@cxf.apache.org
Received: (qmail 75942 invoked by uid 500); 9 Sep 2013 16:13:14 -0000
Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cxf.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cxf.apache.org>
List-Post: <mailto:dev@cxf.apache.org>
List-Id: <dev.cxf.apache.org>
Reply-To: dev@cxf.apache.org
Delivered-To: mailing list dev@cxf.apache.org
Received: (qmail 75923 invoked by uid 99); 9 Sep 2013 16:13:12 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Sep 2013 16:13:12 +0000
X-ASF-Spam-Status: No, hits=0.0 required=5.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: error (athena.apache.org: local policy)
Received: from [64.85.173.253] (HELO server.dankulp.com) (64.85.173.253)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Sep 2013 16:13:08 +0000
Received: by server.dankulp.com (Postfix, from userid 5000)
	id 5CB991859B4; Mon,  9 Sep 2013 12:12:27 -0400 (EDT)
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on server.dankulp.com
X-Spam-Level: 
X-Msg-File: /tmp/mailfilter-dev@cxf.apache.org.vy3A8jmyzA
Received: from macbook.house.dankulp.com (c-24-91-72-253.hsd1.ma.comcast.net
 [24.91.72.253])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by server.dankulp.com (Postfix) with ESMTPSA id ECE811859AF;
	Mon,  9 Sep 2013 12:12:23 -0400 (EDT)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: Problems with m2eclipse and cxf
From: Daniel Kulp <dkulp@apache.org>
In-Reply-To: <522DD543.6020002@die-schneider.net>
Date: Mon, 9 Sep 2013 12:12:23 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <2433F952-BEF5-4CB3-AEFF-4E18AEC19021@apache.org>
References: <522DD543.6020002@die-schneider.net>
To: dev@cxf.apache.org,
 Christian Schneider <chris@die-schneider.net>
X-Mailer: Apple Mail (2.1508)
X-Virus-Checked: Checked by ClamAV on apache.org
X-Old-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00
	shortcircuit=no autolearn=unavailable version=3.3.2


If you tell m2eclipse to import the projects with the m2eclipse profile =
enabled, then it switched to a different PMD ruleset that doesn't have =
the custom rule.

That said, I do have to wonder if we really need the custom rule =
anymore.   It's just to trap calls to "new String(byte[])" which has =
issues due to the machine specific encoding.    I just did some checking =
and that check is no longer working outside of eclipse either.   Might =
as well just get rid of it.

Dan



On Sep 9, 2013, at 10:03 AM, Christian Schneider =
<chris@die-schneider.net> wrote:

> I am working on CXF using m2eclipse.
>=20
> When I import projects using m2eclipse or update the maven project I =
always get an error that contains:
> PMD UnsafeStringConstructorRule
>=20
> So it seems m2eclipse configures pmd but can not find the custom rule.
>=20
> I was able to get it running by removing this line in the parent pom.
> <ruleset>${cxf.resources.base.path}cxf-pmd-custom.xml</ruleset>
>=20
> This line seems to add the problematic rule.
>=20
> Can this be fixed in a better way?
> Do we really need these PMD checks in eclipse?
>=20
> Christian
>=20
>=20
> --=20
> Christian Schneider
> http://www.liquid-reality.de
>=20
> Open Source Architect
> http://www.talend.com
>=20

--=20
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com