cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: Typo error for null checking in EndpointImpl ?
Date Fri, 15 Mar 2013 20:51:45 GMT

Yea, a bug.   The check really shouldn't even be there.   It should just be other.remove(o)
no matter if its null or not.   Fixed.


Dan



On Mar 15, 2013, at 2:22 AM, Ivan <xhhsld@gmail.com> wrote:

> Hi, I found the codes below in the org.apache.cxf.jaxws.EndpointImpl (line
> 691)
> 
> public Interceptor<? extends Message> remove(int index) {
>            Interceptor<? extends Message> o = orig.remove(index);
>            if (o == null) {   <--- Is it a typo error ? Should be != null
>                other.remove(o);
>            }
>            return o;
>        }
> 
> -- 
> Ivan

-- 
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com


Mime
View raw message