Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: svn commit: r1408627 -
 /cxf/trunk/rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/interceptor/SoapOutInterceptor.java
From: Daniel Kulp <dkulp@apache.org>
In-Reply-To: <20121113075015.471752388993@eris.apache.org>
Date: Tue, 13 Nov 2012 07:12:21 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <45F6891C-BEF8-4147-B27D-848266ED92A4@apache.org>
References: <20121113075015.471752388993@eris.apache.org>
To: dev@cxf.apache.org,
 ffang@apache.org


Umm=85   this puts a dependency on the jaxws API from the soap binding =
which would be a new dep.   That's "OK" for trunk since the JAX-WS API's =
are built in the JDK, but that wouldn't be ok to be merged back.  =20

Ideally, this should be done somehow in the JAXWS layer.  Most likely, =
after the invoke completes, the JAXWS invoker should remove the callback =
off of the param list.

Dan


On Nov 13, 2012, at 2:50 AM, ffang@apache.org wrote:

> Author: ffang
> Date: Tue Nov 13 07:50:14 2012
> New Revision: 1408627
>=20
> URL: http://svn.apache.org/viewvc?rev=3D1408627&view=3Drev
> Log:
> [CXF-4623]Marshalling Error during asynchronous service invocation =
when adding a soap header using a SOAPHandler
>=20
> Modified:
>    =
cxf/trunk/rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/inter=
ceptor/SoapOutInterceptor.java
>=20
> Modified: =
cxf/trunk/rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/inter=
ceptor/SoapOutInterceptor.java
> URL: =
http://svn.apache.org/viewvc/cxf/trunk/rt/bindings/soap/src/main/java/org/=
apache/cxf/binding/soap/interceptor/SoapOutInterceptor.java?rev=3D1408627&=
r1=3D1408626&r2=3D1408627&view=3Ddiff
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- =
cxf/trunk/rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/inter=
ceptor/SoapOutInterceptor.java (original)
> +++ =
cxf/trunk/rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/inter=
ceptor/SoapOutInterceptor.java Tue Nov 13 07:50:14 2012
> @@ -27,6 +27,7 @@ import java.util.ResourceBundle;
>=20
> import javax.xml.stream.XMLStreamException;
> import javax.xml.stream.XMLStreamWriter;
> +import javax.xml.ws.AsyncHandler;
>=20
> import org.w3c.dom.Element;
>=20
> @@ -212,13 +213,20 @@ public class SoapOutInterceptor extends=20
>             if (headers =3D=3D null) {
>                 return endedHeader;
>             }           =20
> +           =20
>=20
>             for (SoapHeaderInfo header : headers) {
>                 MessagePartInfo part =3D header.getPart();
>                 if (wrappedBmi !=3D bmi) {
>                     part =3D =
wrappedBmi.getMessageInfo().addMessagePart(part.getName());
>                 }
> -                if (part.getIndex() >=3D objs.size()) {
> +                int paraLength =3D objs.size();
> +                if (objs.get(paraLength - 1) instanceof AsyncHandler) =
{
> +                    //when use asyn handler in bare mode the last =
parameter is AsyncHandler
> +                    //which shouldn't count in as parameter length
> +                    paraLength =3D paraLength - 1;
> +                }
> +                if (part.getIndex() >=3D paraLength) {
>                     // The optional out of band header is not a part =
of parameters of the method
>                     continue;
>                 }
>=20
>=20

--=20
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com