Return-Path: X-Original-To: apmail-cxf-dev-archive@www.apache.org Delivered-To: apmail-cxf-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 845BDD86D for ; Wed, 31 Oct 2012 14:50:02 +0000 (UTC) Received: (qmail 59211 invoked by uid 500); 31 Oct 2012 14:50:01 -0000 Delivered-To: apmail-cxf-dev-archive@cxf.apache.org Received: (qmail 58957 invoked by uid 500); 31 Oct 2012 14:50:01 -0000 Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list dev@cxf.apache.org Received: (qmail 58935 invoked by uid 99); 31 Oct 2012 14:50:00 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Oct 2012 14:50:00 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of david.bosschaert@gmail.com designates 209.85.219.41 as permitted sender) Received: from [209.85.219.41] (HELO mail-oa0-f41.google.com) (209.85.219.41) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Oct 2012 14:49:55 +0000 Received: by mail-oa0-f41.google.com with SMTP id k14so1701769oag.0 for ; Wed, 31 Oct 2012 07:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; bh=5y9SJxc9s6c/smmXbcfQH6+jzDKbxV8txjTm4jOAnmM=; b=BETOqamKHzvgCnp3jYa/oPeNwDbtFYFXOZzRA0u3rQRF3Guiu6hlcnZyhKz5MSF1WN JyKi6gF+gyxHtFhR3BWvfH/cs9S+vOQ1/YKvdDxsw7rM1V6rvU2wJjDkQTgs0W/JjpS0 H3uYWs8qSMmUl+fkeaE66VC5IVW/TjQXsvgtZ1jsPBog2yktWkiYH5OmjrIK4T4K1bNb diduIpq+n9XftJ5E1LRA5T8MuZ1TALWUQM0lJ2I7JwaAAPIT6xW6dkl1HErryAu3CdMX LqHSZ/SdxRH4ElwWTX0HlcAz3tfxW3N5J/3Vxcqvt9lnNlmIG0uIllujhndTmSQklFPG Vexg== Received: by 10.182.49.104 with SMTP id t8mr30807698obn.0.1351694974000; Wed, 31 Oct 2012 07:49:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.24.167 with HTTP; Wed, 31 Oct 2012 07:49:13 -0700 (PDT) In-Reply-To: References: <50910853.5060701@die-schneider.net> From: David Bosschaert Date: Wed, 31 Oct 2012 14:49:13 +0000 Message-ID: Subject: Re: CXF-DSOGI: Proposal to switch logging to slf4j To: dev@cxf.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org No objection from me either. Best regards, David On 31 October 2012 14:45, Daniel Kulp wrote: > > On Oct 31, 2012, at 7:15 AM, Christian Schneider wrote: > >> Hi all, >> >> currently we use a mix of log4j and util logging in CXF-DOSGi. > > That definitely should be fixed. Not sure why we would have had a mix l= ike that. > > >> I just saw that zookeeper changed their logging to slf4j. It seems their= current release is not completely correct but I am sure they will soon wor= k fine with just slf4j as an import. >> As CXF-DOSGi only runs on OSGi and slf4j is the simplest way to support = logging on OSGi I propose we switch the logging to slf4j. So we are in line= with Apache Karaf and Zookeeper. > > The main concern I would have had is if any of the CXF-DOSGi code used th= e Messages.properties resource bundles for the logging messages like the ma= in CXF code does. However, I just did a quick search through the DOSGi cod= e and don't see any of them. Apparently not used there. > > Thus, I don't really have any major objection to it. > > Dan > > >> Please also see the two related issues in jira: >> https://issues.apache.org/jira/browse/DOSGI-135 >> https://issues.apache.org/jira/browse/DOSGI-132 >> >> So what do you think? >> >> Best regards >> >> Christian > > -- > Daniel Kulp > dkulp@apache.org - http://dankulp.com/blog > Talend Community Coder - http://coders.talend.com >