Return-Path: X-Original-To: apmail-cxf-dev-archive@www.apache.org Delivered-To: apmail-cxf-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 42595788E for ; Tue, 18 Oct 2011 11:57:12 +0000 (UTC) Received: (qmail 18106 invoked by uid 500); 18 Oct 2011 11:57:12 -0000 Delivered-To: apmail-cxf-dev-archive@cxf.apache.org Received: (qmail 18013 invoked by uid 500); 18 Oct 2011 11:57:11 -0000 Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cxf.apache.org Delivered-To: mailing list dev@cxf.apache.org Received: (qmail 18005 invoked by uid 99); 18 Oct 2011 11:57:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Oct 2011 11:57:11 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of willem.jiang@gmail.com designates 209.85.210.169 as permitted sender) Received: from [209.85.210.169] (HELO mail-iy0-f169.google.com) (209.85.210.169) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Oct 2011 11:57:04 +0000 Received: by iagf6 with SMTP id f6so771555iag.0 for ; Tue, 18 Oct 2011 04:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=M4XxzyC6TSY6NnU0peJd2PX6Cilj1ZJ5tj8Rkg/Rwtc=; b=JBHXuOqpOWpSU4XskKGPBQX5eeUvtLD0Ef0z4Bscuhl3+cbxep90oTwIREy8KqYTLv RoyGafkB2qC61nBOMA1yI3ge/fKp+foiCm0NWcv8MonNvkioncheUr+XKQ2g9Co7u8zm cYM4h5VivaPLFKLTd+t2DmgqVReMBp3CjwsCM= Received: by 10.42.157.135 with SMTP id d7mr4229343icx.19.1318939002769; Tue, 18 Oct 2011 04:56:42 -0700 (PDT) Received: from [192.168.0.158] ([123.116.32.153]) by mx.google.com with ESMTPS id n30sm5150546ibl.4.2011.10.18.04.56.38 (version=SSLv3 cipher=OTHER); Tue, 18 Oct 2011 04:56:40 -0700 (PDT) Message-ID: <4E9D6970.5090306@gmail.com> Date: Tue, 18 Oct 2011 19:56:32 +0800 From: Willem Jiang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: dev@cxf.apache.org Subject: Re: svn commit: r1182802 - in /cxf/branches/2.4.x-fixes: ./ rt/core/src/main/java/org/apache/cxf/databinding/source/ References: <20111013123046.8552D238890A@eris.apache.org> <4E9C5E83.2020806@talend.com> In-Reply-To: <4E9C5E83.2020806@talend.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hi Glen, Thanks for pointing that out, I already committed the fix for it. On Tue Oct 18 00:57:39 2011, Glen Mazza wrote: > On 10/13/2011 08:30 AM, ningjiang@apache.org wrote: >> Author: ningjiang >> Date: Thu Oct 13 12:30:45 2011 >> New Revision: 1182802 >> >> URL: http://svn.apache.org/viewvc?rev=1182802&view=rev >> Log: >> Merged revisions 1182754 via svnmerge from >> https://svn.apache.org/repos/asf/cxf/trunk >> >> ........ >> r1182754 | ningjiang | 2011-10-13 18:08:19 +0800 (Thu, 13 Oct 2011) | >> 1 line >> >> CXF-3858 Added the cause exception class name into the fault message >> ........ >> >> Modified: >> cxf/branches/2.4.x-fixes/ (props changed) >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/Messages.properties >> >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/NodeDataReader.java >> >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/NodeDataWriter.java >> >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/XMLStreamDataReader.java >> >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/XMLStreamDataWriter.java >> >> >> Propchange: cxf/branches/2.4.x-fixes/ >> ------------------------------------------------------------------------------ >> >> --- svn:mergeinfo (original) >> +++ svn:mergeinfo Thu Oct 13 12:30:45 2011 >> @@ -1 +1 @@ >> -/cxf/trunk:1179846,1180649,1180653,1181611-1181612,1182637,1182715-1182717,1182752 >> >> +/cxf/trunk:1179846,1180649,1180653,1181611-1181612,1182637,1182715-1182717,1182752,1182754 >> >> >> Propchange: cxf/branches/2.4.x-fixes/ >> ------------------------------------------------------------------------------ >> >> Binary property 'svnmerge-integrated' - no diff available. >> >> Modified: >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/Messages.properties >> >> URL: >> http://svn.apache.org/viewvc/cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/Messages.properties?rev=1182802&r1=1182801&r2=1182802&view=diff >> >> ============================================================================== >> >> --- >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/Messages.properties >> (original) >> +++ >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/Messages.properties >> Thu Oct 13 12:30:45 2011 >> @@ -20,5 +20,5 @@ >> # >> COULD_NOT_READ_XML_STREAM = Could not parse the XML stream. >> COULD_NOT_WRITE_XML_STREAM = Could not generate the XML stream. >> -COULD_NOT_REDA_XML_STREAM_CAUSED_BY = Could not parse the XML stream >> caused by {0}. >> -COULD_NOT_WRITE_XML_STREAM_CAUSED_BY = Could not generate the XML >> stream caused by {0}. >> +COULD_NOT_REDA_XML_STREAM_CAUSED_BY = Could not parse the XML stream >> caused by: {0}: {1}. >> +COULD_NOT_WRITE_XML_STREAM_CAUSED_BY = Could not generate the XML >> stream caused by: {0}: {1}. >> > > Needs to be spelled "COULD_NOT_READ_..." :) > > Glen > > >> Modified: >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/NodeDataReader.java >> >> URL: >> http://svn.apache.org/viewvc/cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/NodeDataReader.java?rev=1182802&r1=1182801&r2=1182802&view=diff >> >> ============================================================================== >> >> --- >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/NodeDataReader.java >> (original) >> +++ >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/NodeDataReader.java >> Thu Oct 13 12:30:45 2011 >> @@ -66,7 +66,8 @@ public class NodeDataReader implements D >> } catch (IOException e) { >> throw new Fault("COULD_NOT_READ_XML_STREAM", LOG, e); >> } catch (TransformerException e) { >> - throw new Fault("COULD_NOT_REDA_XML_STREAM_CAUSED_BY", LOG, e, >> e.getMessage()); >> + throw new Fault("COULD_NOT_REDA_XML_STREAM_CAUSED_BY", LOG, e, >> + e.getClass().getCanonicalName(), e.getMessage()); >> } >> } >> return read(input); >> >> >> >> Modified: >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/XMLStreamDataReader.java >> >> URL: >> http://svn.apache.org/viewvc/cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/XMLStreamDataReader.java?rev=1182802&r1=1182801&r2=1182802&view=diff >> >> ============================================================================== >> >> --- >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/XMLStreamDataReader.java >> (original) >> +++ >> cxf/branches/2.4.x-fixes/rt/core/src/main/java/org/apache/cxf/databinding/source/XMLStreamDataReader.java >> Thu Oct 13 12:30:45 2011 >> @@ -139,9 +139,11 @@ public class XMLStreamDataReader impleme >> } catch (IOException e) { >> throw new Fault("COULD_NOT_READ_XML_STREAM", LOG, e); >> } catch (XMLStreamException e) { >> - throw new Fault("COULD_NOT_REDA_XML_STREAM_CAUSED_BY", LOG, e, >> e.getMessage()); >> + throw new Fault("COULD_NOT_REDA_XML_STREAM_CAUSED_BY", LOG, e, >> + e.getClass().getCanonicalName(), e.getMessage()); >> } catch (SAXException e) { >> - throw new Fault("COULD_NOT_REDA_XML_STREAM_CAUSED_BY", LOG, e, >> e.getMessage()); >> + throw new Fault("COULD_NOT_REDA_XML_STREAM_CAUSED_BY", LOG, e, >> + e.getClass().getCanonicalName(), e.getMessage()); >> } >> } >> >> @@ -225,7 +227,8 @@ public class XMLStreamDataReader impleme >> return new DOMSource(document); >> } >> } catch (XMLStreamException e) { >> - throw new Fault("COULD_NOT_REDA_XML_STREAM_CAUSED_BY", LOG, e, >> e.getMessage()); >> + throw new Fault("COULD_NOT_REDA_XML_STREAM_CAUSED_BY", LOG, e, >> + e.getClass().getCanonicalName(), e.getMessage()); >> } >> } >> >> >> >> > > -- Willem ---------------------------------- FuseSource Web: http://www.fusesource.com Blog: http://willemjiang.blogspot.com (English) http://jnn.javaeye.com (Chinese) Twitter: willemjiang Weibo: willemjiang