cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrzej Michalec <andrzej.micha...@gmail.com>
Subject Re: SeachConditionBuilder for CXF JAX-RS clients
Date Sun, 06 Mar 2011 21:36:45 GMT

Sergey Beryozkin-5 wrote:
> 
> I'm concerned about it.
> I've seen the relevant JAXRSClientSeverBookTest being disabled and I'm
> honestly not sure why
> given
> _s=id==2
> 

You could use this query on "id==2" and it worked (you have made unit/system
tests). The trick is that when one would make up a query with "name==CXF*"
only, without id, this certailny fails since id is internally set to zero
instead of null  Since unit/system tests accidentally used all primitve type
fields in queries (I mean "id") everything worked fine. Now the tests are
broken (and disabled) because I added sanity check inside
SimpleSearchCondition which denies work it type T contains primitive types.
If Book class had "id" type of Integer, instead of int, it would work as a
charm. But it makes too mach of a hastle and as I confirmed it is
unnecessary constraint I overlooked, so I just need to take care of the code
I committed and replace comparison mechanism in SimpleSearchCondition, plus
wire it back in FiqlParser.

Sergey, do you plan this featrue part of 2.4 release, right? Just let me
know what deadline is to see if I can handle this change on time.

Regarding user perspective and how SearchConditionBuilder is a factory for
builders, maybe in future other than FIQL -- sounds reasonable, will take
care of it too.

cheers,
-andy.

--
View this message in context: http://cxf.547215.n5.nabble.com/SeachConditionBuilder-for-CXF-JAX-RS-clients-tp3357826p3411767.html
Sent from the cxf-dev mailing list archive at Nabble.com.

Mime
View raw message