cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Oponowicz <tomasz.oponow...@gmail.com>
Subject Re: LogBrowser project is on the trunk
Date Thu, 24 Feb 2011 09:26:53 GMT
Hi Sergey,

On Thu, Feb 17, 2011 at 12:34 PM, Sergey Beryozkin <sberyozkin@gmail.com> wrote:
> Hi Tomasz
>>>>>
>>>>> 1. LogBrowser has a showstopper bug which I'm sure is due to the fact
we
>>>>> just did not look at it for a while :-). Basically, when I go and generate
>>>>> the logs, and then click 'refresh' on the endpoint, the browser reports
an
>>>>> exception.
>>
>> I can't reproduce this (however it doesn't mean that there isn't bug ;) ).
>>
>> To solidify my understanding, use case:
>>
>> 1) Run 'logbrowser' through sample;
>> 2) Go to 'http://localhost:9002/log/browser/LogBrowser.html';
>> 3) Add new endpoint with URL 'http://localhost:9002/log/logs';
>> 4) Select newly created endpoint;
>> 5) In new tab open 'http://localhost:9002/customer-service.html' and
>> add few 'customers';
>> 6) Go back to 'logbrowser';
>> 6) Click 'refresh' link;
>>
>> Expected:
>> List is refreshed and new items are shown.
>>
>> Environment:
>> Firefox 3.6.x
>>
>> Is this use case correct? Thanks for your help.
>>
>
> It is, I'll try again asap - definitely looks like a platform/browser
> specific issue, it's Ubuntu 9 + FireFox 3.6.13 which I upgraded to
> recently using the apt-get facility...So I'm not worried really then,
> but I'll try again, and on Windows too...
>
>> Maybe try with force refresh (i.e. "Ctrl + R"). However I have to add
>> revision number to static resources URL to avoid cache problems.
>>
>>> this is is the only main issue at the moment
>>>>>
>>>>> 2. Please move ManageEndpoints button either immediately above or below
the
>>>>> Filter button
>>>>
>>>> You mean something similar to "original" layout - "Manage endpoint" is
>>>> "attached" to the bottom of the page?
>>>>
>>>
>>> I'm thinking that given we have a Filter button in the bottom of the
>>> left-side pane, it would be ok to have both 'Manage Endpoints' and
>>> 'Filters' co-located...
>>>
>>>>> 3. Remove the Tasks and Endpoints buttons/entries, lets have it the way
you
>>>>> did it originally. We only need to  see the list of endpoints which
will be
>>>>> added via "ManageEndpoints", the explorer style is just too complex.

According to 2, 3:

I left old layout, but I fixed CSS. It looks really nice now.

We need layout which is easy to extend. Section "tasks" give us
ability to add new actions later. I think it makes sense to keep this
layout.

>>>>> 4. When I go to ManageEndpoints, "Sign Out" leaks into the new panel
and
>>>>> overlaps with the "Settings" entry,
>>
>> Fixed.
>
> Super
>
>>
>>>> Looks like 2, 3, 4 are layout problems... I have to clean up this. At
>>>> the moment we are using mix of CSS and "table layout". I'm not CSS
>>>> expert so I will fix it by moving problematic parts to "table layout".

In general I committed many layout fixes.

>> I noticed that when you use latest Chrome or Safari, list of logs and
>> detailed view isn't shown. I consider this as a blocker. I will
>> prepare fix for this ASAP.

Fixed.

> May be it's somehow related to what I see with the application
> exception above...
>
> What I will need to do is to provide an abstract utility
> ReadableStorage implementation which can be easily overridden to have
> the file-based logs viewable. I don't think we can make LogBrowser
> perfect and feature-complete by the 2.4.0 is released, but hope users
> will give it a try anyway...
>
> Few other "would be nice to fix" issues - definitely not show stoppers :
> - LogBrowser has the 'embedded' providers, one for servicing the
> gzipped file and another one for unqualified JSON, this would be nice
> to move to the demo's Application (JSONProvider can be configured
> directly to drop the namespaces) - I can look into it
> - Authentication: I've noticed there's AuthenticationRequired
> annotation attached to some of the BootstrapStorage methods - we
> really need to remove this annotation and for now just pop-up a login
> window on the browser start-up.
> Users will be configuring the LogBrowser application as part of the
> real deployments. So what would be good is to write the GWT client
> code such that it only pops up a window  when the initial GET returns
> 401 - can you use CXF WebClient there and do 'Response r =
> webClient.get()' and if r.getStatus() == 401 then pop-up a login
> dialog ? We can deal with this issue later, when we have more time,
> and then we'll also decide whether to support https in cases when the
> authentication is needed or may be do the UT profile, we'll see...

According to your list of tasks please consider also fallowing tasks:

- Removing "Sign in" feature;
    - Pros:
         - Simplify implementation;
         - Easy configuration for end user;
         - Every company has got their own internal user
authentication system (LDAP, OpenID, internal SSO etc.);
         - Even if LogBrowser doesn't contain any user authentication
system, it's still very easy to add integration with some
authentication system:
                 - Simply interceptor before request rich controller;
                 - Apache directives (of course if user use Apache
before Tomcat);
    - Cons:
         - I understand that feeds should be secured, but I think we
should rather concentrate on:
                 - HTTPS connection;
                 - password per feed (optional);

- Removing storing user settings remotely on the servers;
    - Pros:
         - Simplify implementation;
         - Easy configuration for end user;
         - Very clear message - all settings are stored in browser
local storage. At the moment the logic it's to complicated. It depend
on situation we keep settings in memory, browser local storage or
bootstrap settings;
    - Cons:
         - When end user clear cache all settings will be removed;
         - Settings are stored per browser. When you add something in
Firefox it won't be available in Chrome;

What do you think about these tasks? I'd like to keep LogBrowser minimalistic.

> Thanks, Sergey.
>
>>
>> --
>> Best regards,
>> Tomasz Oponowicz
>>
>



-- 
Best regards,
Tomasz Oponowicz

Mime
View raw message