cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Willem Jiang <willem.ji...@gmail.com>
Subject Re: Typo in LoggingInInterceptor constructor?
Date Fri, 11 Feb 2011 09:26:06 GMT
Hi Glen,

Your fix has some side effect, I just committed another patch[1] to fix 
the test error of SecurityPolicyTest.

[1]http://svn.apache.org/viewvc?rev=1069716&view=rev

Willem

On 2/10/11 11:47 PM, Glen Mazza wrote:
> Fixed on 2.3.2 and upcoming 2.4. Also, I checked the official CXF
> treasury ($0.00), sorry no money for the Monster drink.
>
> Thanks,
> Glen
>
> On 09.02.2011 14:40, Glen Mazza wrote:
>> Hmm, seems like the CXF team owes Aaron a Monster energy drink (unless
>> he's become partial to other beverages).
>>
>> Glen
>>
>> On 09.02.2011 14:00, Pieper, Aaron wrote:
>>> Is there a typo in the LoggingInInterceptor(String,String) constructor?
>>> It seems to inaccurately call super(id, id) instead of super(id, phase).
>>> I'm looking at r1058274 which appears to be the latest:
>>>
>>>
>>>
>>> http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/
>>> cxf/interceptor/LoggingInInterceptor.java?revision=1058274&view=markup
>>>
>>>
>>>
>>> It seems accidental, given the invocations on lines 55 and 64 which
>>> wouldn't make much sense if it were deliberate.
>>>
>>> - Aaron
>>>
>>
>
>


-- 
Willem
----------------------------------
FuseSource
Web: http://www.fusesource.com
Blog:    http://willemjiang.blogspot.com (English)
          http://jnn.javaeye.com (Chinese)
Twitter: willemjiang

Mime
View raw message