cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: Pom editing and joining the community in general
Date Sat, 30 Oct 2010 03:00:28 GMT
On Friday 29 October 2010 5:33:39 pm Robert J. Liguori wrote:
> Sorry, can't help here...  I'm just trying to get up to speed with CXF and
> providing my input as I go along.
> 
> Perhaps I should hold back on my input until I am more familiar with the
> framework.

No.  Don't worry about that issue.   One of the best ways of learning is to 
dig in, ask questions, try things out.   

What Benson is more or less alluding to, though, is that it's probably a good 
idea to tackle things that would just have smaller, localized scopes of 
affects as a starting point and then work larger.   Mucking with the top level 
poms is a global scope kind of thing that can impact huge chunks of the build, 
affects things like the automated builds we have running on hudson, eclipse 
setups, the kit building,  etc....   Thus, changes there need to be done in 
very small, well reviewed steps.   A big patch that does a lot at once doesn't 
work very well.   

From your other issues you've logged, updating javadocs, fixing compiler 
warnings, dealing with deprecation issues, etc... are all more or less 
localized things which are perfect.   

Dan



> 
> Thank you for expressing your concerns,
> Robert
> 
> --------------------------------------------------
> From: "Benson Margulies" <bimargulies@gmail.com>
> Sent: Friday, October 29, 2010 5:29 PM
> To: <robert@gliesian.com>; "CXF Dev" <dev@cxf.apache.org>
> Subject: Pom editing and joining the community in general
> 
> > Robert,
> > 
> > I wouldn't want you to get the wrong impression from the comments on
> > your JIRA related to the top-level POM.
> > 
> > There is a trust issue, and it related to the essential fragility of
> > maven poms. You've picked the one central location where a change
> > could do just about maximal damage to the builds.
> > 
> > I've seen builds completely decompose from a plugin version update.
> > The Maven Gang sometimes leaves something to be desired in the testing
> > department.
> > 
> > Modulo Dan and my specific opinions about particular aspects of this,
> > the big question is testing. Have you tried all the profiles? On both
> > Maven 2.2.x and 3.0? Including -Psetup.eclipse, and the
> > release-building pieces?
> > 
> > It would be less exciting if you'd start by offering up rather more
> > local patches, heaven knows we've got plenty of open JIRAs. However,
> > if build engineering is what floats your boat, go right ahead and test
> > this stuff out. I'll be happy to review and apply as appropriate.
> > 
> > --benson

-- 
Daniel Kulp
dkulp@apache.org
http://dankulp.com/blog

Mime
View raw message