Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Received-SPF: pass (nike.apache.org: domain of bimargulies@gmail.com
 designates 74.125.82.169 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=V/E4pFjwuzGa5Gki9iZACgwgt6dWTCuywQS+tC/eTGFsNiUGjk8rWB12wKXNR7stiX
         B28MeJ5JzmaP93vR2YeHM964mTZL9Qeork+E/r8Dj/hFWQAdlLrjcQx7JCESssaNtgxP
         U6VhPz4/GaomvqxnY7sMF4V/wsjFS0rz36urU=
MIME-Version: 1.0
In-Reply-To: <4C538151.7020102@gmail.com>
References: <20100730160740.AA5DA23889DA@eris.apache.org>
	<4C538151.7020102@gmail.com>
Date: Sat, 31 Jul 2010 07:52:01 -0400
Message-ID: <AANLkTimwHYVwfxKz3pYQF6Ofbi4Pr2wJoxGNh--6zTgj@mail.gmail.com>
Subject: Re: Need for normalization? (Re: svn commit: r980880 - in
	/cxf/trunk/tools/common/src)
From: Benson Margulies <bimargulies@gmail.com>
To: dev@cxf.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

To chime in: it's a really, really, bad idea for non-file URLs, as it
can violate stringprep.

For file URLs, it is an attempt to deal, with non-NFC (or NFKC)
strings in the URL failing to match the file system. However, file
system normalization is platform-dependendent. Linux does none at all,
for example. So it's not safe in general.


On Fri, Jul 30, 2010 at 9:50 PM, Glen Mazza <glen.mazza@gmail.com> wrote:
> May I ask why this normalization is helpful (instead of just using the
> intended file path to being with)?
> Does this affect just internal CXF use or external usage by users of CXF?
> =C2=A0If the latter, the potential problem I see is that not all URI's ar=
e file
> paths and, even if they were, I'm not sure that you can safely normalize =
in
> a platform-independent manner.
>
> Glen
>
> ema@apache.org wrote:
>>
>> Author: ema
>> Date: Fri Jul 30 16:07:40 2010
>> New Revision: 980880
>>
>> URL: http://svn.apache.org/viewvc?rev=3D980880&view=3Drev
>> Log:
>> [CXF-2918]:normalize the url like file:/home/cxf/org/apache/../../cxf in
>> URIParserUtil.getAbsoluteURL()
>>
>> Modified:
>>
>> =C2=A0cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/URI=
ParserUtil.java
>>
>> =C2=A0cxf/trunk/tools/common/src/test/java/org/apache/cxf/tools/util/URI=
ParserUtilTest.java
>>
>> Modified:
>> cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/URIParser=
Util.java
>> URL:
>> http://svn.apache.org/viewvc/cxf/trunk/tools/common/src/main/java/org/ap=
ache/cxf/tools/util/URIParserUtil.java?rev=3D980880&r1=3D980879&r2=3D980880=
&view=3Ddiff
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> ---
>> cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/URIParser=
Util.java
>> (original)
>> +++
>> cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/URIParser=
Util.java
>> Fri Jul 30 16:07:40 2010
>> @@ -248,18 +248,15 @@ public final class URIParserUtil {
>> =C2=A0 =C2=A0 }
>> =C2=A0 =C2=A0 public static String normalize(final String uri) {
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 URL url =3D null;
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0String result =3D null;
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 try {
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 url =3D new URL(uri);
>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return escapeChars(url.toStri=
ng().replace("\\", "/"));
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0result =3D
>> escapeChars(url.toURI().normalize().toString().replace("\\", "/"));
>>
>
>
>