Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Received-SPF: pass (athena.apache.org: domain of glen.mazza@gmail.com
 designates 209.85.216.176 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=tJbjizqL3offC0k/jgtRLxnrZr46d7NCMaBAT0OjKoaaj8TQIqpjLA9tMsD1e3U6j6
         FL6bOvFvqBoTgcWMMYmBvdj15ZMLsbiZ8KYRb6lqS0ODu3HswcwtEO1U4GiM+kIj9pg3
         5/PJSbr/zXmR56J8aSw1riT930R+wOQJZI4nc=
Message-ID: <4C538151.7020102@gmail.com>
Date: Fri, 30 Jul 2010 21:50:09 -0400
From: Glen Mazza <glen.mazza@gmail.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20100317)
MIME-Version: 1.0
To: dev@cxf.apache.org
Subject: Need for normalization? (Re: svn commit: r980880 - in
 /cxf/trunk/tools/common/src)
References: <20100730160740.AA5DA23889DA@eris.apache.org>
In-Reply-To: <20100730160740.AA5DA23889DA@eris.apache.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

May I ask why this normalization is helpful (instead of just using the 
intended file path to being with)?
Does this affect just internal CXF use or external usage by users of 
CXF?  If the latter, the potential problem I see is that not all URI's 
are file paths and, even if they were, I'm not sure that you can safely 
normalize in a platform-independent manner.

Glen

ema@apache.org wrote:
> Author: ema
> Date: Fri Jul 30 16:07:40 2010
> New Revision: 980880
>
> URL: http://svn.apache.org/viewvc?rev=980880&view=rev
> Log:
> [CXF-2918]:normalize the url like file:/home/cxf/org/apache/../../cxf in URIParserUtil.getAbsoluteURL()
>
> Modified:
>     cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/URIParserUtil.java
>     cxf/trunk/tools/common/src/test/java/org/apache/cxf/tools/util/URIParserUtilTest.java
>
> Modified: cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/URIParserUtil.java
> URL: http://svn.apache.org/viewvc/cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/URIParserUtil.java?rev=980880&r1=980879&r2=980880&view=diff
> ==============================================================================
> --- cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/URIParserUtil.java (original)
> +++ cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/util/URIParserUtil.java Fri Jul 30 16:07:40 2010
> @@ -248,18 +248,15 @@ public final class URIParserUtil {
>      }
>      public static String normalize(final String uri) {
>          URL url = null;
> +        String result = null;
>          try {
>              url = new URL(uri);
> -            return escapeChars(url.toString().replace("\\", "/"));
> +            result = escapeChars(url.toURI().normalize().toString().replace("\\", "/"));
>