cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: svn commit: r750522 - in /cxf/trunk: common/common/src/main/java/org/apache/cxf/common/util/ rt/core/src/main/java/org/apache/cxf/bus/spring/ rt/core/src/main/java/org/apache/cxf/interceptor/ rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/ext/ rt...
Date Thu, 05 Mar 2009 18:39:25 GMT
On Thu March 5 2009 12:52:21 pm sergeyb@apache.org wrote:
>          CachingXmlEventWriter cache = null;
>          
> -        if (shouldValidate(message) && !isRequestor(message)) {
> -            //need to cache the events in case validation fails
> +        // need to cache the events in case validation fails or buffering
> is enabled +        if (shouldValidate(message) && !isRequestor(message)
> +            || SystemUtils.isBufferingEnabled()) {
>              cache = new CachingXmlEventWriter();
>              try {

This definitely shouldn't be based on a system property.   It should be 
something like:

message.getContextualProperty("org.apache.cxf.buffer.output")

or similar so it can be configured on a per-endpoint basis.


-- 
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog

Mime
View raw message