Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Received-SPF: pass (athena.apache.org: domain of willem.jiang@gmail.com
 designates 209.85.142.188 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:x-enigmail-version:content-type
         :content-transfer-encoding;
        b=QpgwFOq9LuK8B4LL3sqYYVRTj6iGfvw9O4Djs80/ChXEPYIY6m61ZVHyiNSCbMrnP2
         tFGaXWkeBbYzcLMbr2Bx3OcoVHIhYHMH1TvqF9H/w7qipkWVvyyN9gyzsrAQkG+stKTC
         mbBhta1PnmKEDkJVZTetK/xRKnzJRE4WAwhgg=
Message-ID: <495097CD.30607@gmail.com>
Date: Tue, 23 Dec 2008 15:48:29 +0800
From: Willem Jiang <willem.jiang@gmail.com>
User-Agent: Thunderbird 2.0.0.18 (Windows/20081105)
MIME-Version: 1.0
To: dev@cxf.apache.org
Subject: Re: Issue with multiple CXF servlets (and proposed fix)
References: 
 <D33A5FB583A9F843BB5A128BE3FD457E90ED37A191@LNWEXMBX0144.msad.ms.com>
 <21138164.post@talk.nabble.com>
In-Reply-To: <21138164.post@talk.nabble.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi

I'm here (no vocation plan for this Christmas).

I just went through the CXFServelet code to refresh my memory, found it
could be cased by not using right bus for the jaxrs endpoint.

Since you include ...cxf.xml in the jaxrs spring configuration file, the
jaxrs endpoint can't take the already created bus of the application
context into consideration. The new created jaxrs endpoint will use its
own context's bus instead using the already configured bus.

To fix this issue , you just need to remove these three imports
>>  <import resource="classpath:META-INF/cxf/cxf.xml" />
>>   <import
>> resource="classpath:META-INF/cxf/cxf-extension-jaxrs-binding.xml" />
>>   <import resource="classpath:META-INF/cxf/cxf-servlet.xml" />
>>

I just write a quick junit test[1] to verify this.

[1] http://svn.apache.org/viewvc?rev=728897&view=rev

Willem

Glen Mazza wrote:
> I would highly recommend waiting until Dan K. reviews this.  He (and perhaps
> Willem) would be in position best to know about all moving parts that may be
> affected by this change.  I suspect he is on holiday leave this week (and
> possibly the next), however.
> 
> Could the problem also be that you specified
> <load-on-startup>1</load-on-startup> for *both* the servlets defined,
> instead of giving them distinct values?  Somehow I doubt that's the issue
> though.
> 
> Glen
> 
> 
> 
> Tong, Gary (FID) wrote:
>> Hello,
>>
>> I'm having issues with creating multiple CXFServlets.  I'm trying to
>> insantiate 2 independent CXF servlets and deploy them at different URLs. 
>> The relevant part of the web.xml looks like:
>>
>>   <servlet>
>>     <servlet-name>test</servlet-name>
>>    
>> <servlet-class>org.apache.cxf.transport.servlet.CXFServlet</servlet-class>
>>     <load-on-startup>1</load-on-startup>
>>     <init-param>
>>       <param-name>config-location</param-name>
>>       <param-value>/WEB-INF/test-servlet.xml</param-value>
>>     </init-param>
>>   </servlet>
>>
>>   <servlet-mapping>
>>     <servlet-name>test</servlet-name>
>>     <url-pattern>/t/*</url-pattern>
>>   </servlet-mapping>
>>
>>   <servlet>
>>     <servlet-name>foo</servlet-name>
>>    
>> <servlet-class>org.apache.cxf.transport.servlet.CXFServlet</servlet-class>
>>     <load-on-startup>1</load-on-startup>
>>     <init-param>
>>       <param-name>config-location</param-name>
>>       <param-value>/WEB-INF/foo-servlet.xml</param-value>
>>     </init-param>
>>   </servlet>
>>
>>   <servlet-mapping>
>>     <servlet-name>foo</servlet-name>
>>     <url-pattern>/f/*</url-pattern>
>>   </servlet-mapping>
>>
>> This, unfortunately, doesn't work.  My test-servlet.xml file looks like:
>>
>> <?xml version="1.0"?>
>> <beans xmlns="http://www.springframework.org/schema/beans"
>>        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>>        xmlns:jaxrs="http://cxf.apache.org/jaxrs"
>>        xsi:schemaLocation="
>> http://www.springframework.org/schema/beans
>> http://www.springframework.org/schema/beans/spring-beans-2.5.xsd
>> http://cxf.apache.org/jaxrs http://cxf.apache.org/schemas/jaxrs.xsd">
>>
>>   <import resource="classpath:META-INF/cxf/cxf.xml" />
>>   <import
>> resource="classpath:META-INF/cxf/cxf-extension-jaxrs-binding.xml" />
>>   <import resource="classpath:META-INF/cxf/cxf-servlet.xml" />
>>
>>   <jaxrs:server id="cxfMapping" address="/">
>>     <jaxrs:serviceBeans>
>>       <ref bean="testController"/>
>>     </jaxrs:serviceBeans>
>>     <jaxrs:extensionMappings>
>>       <entry key="xml" value="application/xml" />
>>     </jaxrs:extensionMappings>
>>   </jaxrs:server>
>>
>>   <bean id="testController" class="test.TestController"/>
>>
>> </beans>
>>
>> And foo-servlet.xml looks much the same.  This configuration gives me a
>> "No service was found." response.  However, if I move the import
>> statements to the base spring application context, both the test and foo
>> servlets end up serving up test-servlet.xml and foo-servlet.xml gets
>> ignored.
>>
>> As far as I can tell, this problem occurs because the configs specified in
>> config-location aren't loaded until the majority of the servlet has been
>> initialized.  Because of this, most of the settings in test-servlet.xml
>> and foo-servlet.xml are ignored during initialization.
>>
>> The order of initialization in CXFServlet seems to be:
>>
>> 1. Find the spring app context.
>> 2. Create a new bus based on the app context.
>> 3. Set up the servlet transport factory
>> 4. Create the controller
>> 5. Load the additional configuration from the config-location servlet
>> param
>>
>> My proposed fix is to change the order of initialization to:
>>
>> 1. Find the spring app context.
>> 2. Load the additional configuration from the config-location servlet
>> param
>> 3. Create a new bus based on the new child context (or original spring app
>> context if there is no additional configuration)
>> 4. Set up the servlet transport factory
>> 5. Create the controller
>>
>> The attached diff does this and fixes the problem that I have with
>> creating two CXFServlets.  Hopefully this is the right way to do this.
>>
>> Thanks,
>> Gary
>> --------------------------------------------------------
>>
>> This is not an offer (or solicitation of an offer) to buy/sell the
>> securities/instruments mentioned or an official confirmation.  Morgan
>> Stanley may deal as principal in or own or act as market maker for
>> securities/instruments mentioned or may advise the issuers.  This is not
>> research and is not from MS Research but it may refer to a research
>> analyst/research report.  Unless indicated, these views are the author's
>> and may differ from those of Morgan Stanley research or others in the
>> Firm.  We do not represent this is accurate or complete and we may not
>> update this.  Past performance is not indicative of future returns.  For
>> additional information, research reports and important disclosures,
>> contact me or see https://secure.ms.com/servlet/cls.  You should not use
>> e-mail to request, authorize or effect the purchase or sale of any
>> security or instrument, to send transfer instructions, or to effect any
>> other transactions.  We cannot guarantee that any such requests received
>> via e-mail will be processed in a timely manner.  This communication is
>> solely for the addressee(s) and may contain confidential information.  We
>> do not waive confidentiality by mistransmission.  Contact me if you do not
>> wish to receive these communications.  In the UK, this communication is
>> directed in the UK to those persons who are professional and eligible
>> counterparties (as defined in the UK Financial Services Authority's
>> rules).
>>
>>
>