Mailing-List: contact dev-help@cxf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cxf.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
From: Daniel Kulp <dkulp@apache.org>
To: dev@cxf.apache.org
Subject: Re: svn commit: r687359 -
 /cxf/branches/2.0.x-fixes/rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/JMSConduit.java
Date: Wed, 20 Aug 2008 10:59:33 -0400
User-Agent: KMail/1.9.9
References: <20080820144312.3D45B238896F@eris.apache.org>
In-Reply-To: <20080820144312.3D45B238896F@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200808201059.33739.dkulp@apache.org>


Freeman,

Why would you copy the headers from the outgoing message to the incoming 
message?    That seems very bizzare to me.   What if you DON'T send with 
MTOM, but the server responds with MTOM.     This doesn't seem like the right 
fix.

To me, you need to get the headers copied into the JMS Message when sending, 
and the copied out of the JMS message when receiving.

Dan


On Wednesday 20 August 2008 10:43:11 am ffang@apache.org wrote:
> Author: ffang
> Date: Wed Aug 20 07:43:11 2008
> New Revision: 687359
>
> URL: http://svn.apache.org/viewvc?rev=687359&view=rev
> Log:
> [CXF-1755]JMSConduit need copy protocol headers to response in Message
>
> Modified:
>    
> cxf/branches/2.0.x-fixes/rt/transports/jms/src/main/java/org/apache/cxf/tra
>nsport/jms/JMSConduit.java
>
> Modified:
> cxf/branches/2.0.x-fixes/rt/transports/jms/src/main/java/org/apache/cxf/tra
>nsport/jms/JMSConduit.java URL:
> http://svn.apache.org/viewvc/cxf/branches/2.0.x-fixes/rt/transports/jms/src
>/main/java/org/apache/cxf/transport/jms/JMSConduit.java?rev=687359&r1=687358
>&r2=687359&view=diff
> ===========================================================================
>=== ---
> cxf/branches/2.0.x-fixes/rt/transports/jms/src/main/java/org/apache/cxf/tra
>nsport/jms/JMSConduit.java (original) +++
> cxf/branches/2.0.x-fixes/rt/transports/jms/src/main/java/org/apache/cxf/tra
>nsport/jms/JMSConduit.java Wed Aug 20 07:43:11 2008 @@ -374,6 +374,7 @@
>              inMessage.put(JMSConstants.JMS_CLIENT_RESPONSE_HEADERS,
>                           
> outMessage.get(JMSConstants.JMS_CLIENT_RESPONSE_HEADERS));
>
> +            inMessage.put(Message.PROTOCOL_HEADERS,
> outMessage.get(Message.PROTOCOL_HEADERS)); getLogger().log(Level.FINE, "The
> Response Message is : [" + response + "]");
>
>              // setup the inMessage response stream


-- 
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog