cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: svn commit: r687359 - /cxf/branches/2.0.x-fixes/rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/JMSConduit.java
Date Wed, 20 Aug 2008 14:59:33 GMT

Freeman,

Why would you copy the headers from the outgoing message to the incoming 
message?    That seems very bizzare to me.   What if you DON'T send with 
MTOM, but the server responds with MTOM.     This doesn't seem like the right 
fix.

To me, you need to get the headers copied into the JMS Message when sending, 
and the copied out of the JMS message when receiving.

Dan


On Wednesday 20 August 2008 10:43:11 am ffang@apache.org wrote:
> Author: ffang
> Date: Wed Aug 20 07:43:11 2008
> New Revision: 687359
>
> URL: http://svn.apache.org/viewvc?rev=687359&view=rev
> Log:
> [CXF-1755]JMSConduit need copy protocol headers to response in Message
>
> Modified:
>    
> cxf/branches/2.0.x-fixes/rt/transports/jms/src/main/java/org/apache/cxf/tra
>nsport/jms/JMSConduit.java
>
> Modified:
> cxf/branches/2.0.x-fixes/rt/transports/jms/src/main/java/org/apache/cxf/tra
>nsport/jms/JMSConduit.java URL:
> http://svn.apache.org/viewvc/cxf/branches/2.0.x-fixes/rt/transports/jms/src
>/main/java/org/apache/cxf/transport/jms/JMSConduit.java?rev=687359&r1=687358
>&r2=687359&view=diff
> ===========================================================================
>=== ---
> cxf/branches/2.0.x-fixes/rt/transports/jms/src/main/java/org/apache/cxf/tra
>nsport/jms/JMSConduit.java (original) +++
> cxf/branches/2.0.x-fixes/rt/transports/jms/src/main/java/org/apache/cxf/tra
>nsport/jms/JMSConduit.java Wed Aug 20 07:43:11 2008 @@ -374,6 +374,7 @@
>              inMessage.put(JMSConstants.JMS_CLIENT_RESPONSE_HEADERS,
>                           
> outMessage.get(JMSConstants.JMS_CLIENT_RESPONSE_HEADERS));
>
> +            inMessage.put(Message.PROTOCOL_HEADERS,
> outMessage.get(Message.PROTOCOL_HEADERS)); getLogger().log(Level.FINE, "The
> Response Message is : [" + response + "]");
>
>              // setup the inMessage response stream



-- 
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog

Mime
View raw message