Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cxf-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of barfitzgerald@gmail.com
 designates 209.85.198.188 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=FKSAFwMiZRd71b2acw5JYXhKfMIoR1ZJB7xAtR7UlXzRCjdC16owWWVaJtBVKNo49eAujx5mXDp1Y13gzZa3uQ8WfcgH3urLvhguca2JVZgaDW0ftP71T7nHZOQF51rh1dBAmnFmfBc+8RM5Ll9aovFIqT/Ovj9k4CBuP+dWEXM=
Message-ID: <6f5a2e920803030354k6b71217p13218c7fb3c037d9@mail.gmail.com>
Date: Mon, 3 Mar 2008 11:54:51 +0000
From: "Barry Fitzgerald" <barfitzgerald@gmail.com>
To: cxf-dev@incubator.apache.org
Subject: Re: JAX-RS Form Encoding Provider
In-Reply-To: <012101c879f9$2959aea0$e002050a@pcgroupiona.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_19392_8520950.1204545291093"
References: <6f5a2e920802271002w5d64c81av3e90bb304b386942@mail.gmail.com>
	 <00cf01c8796f$64556d30$e002050a@pcgroupiona.com>
	 <6f5a2e920802280237m6c067499r22f38ae342603a80@mail.gmail.com>
	 <012101c879f9$2959aea0$e002050a@pcgroupiona.com>

------=_Part_19392_8520950.1204545291093
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

Patch added at: https://issues.apache.org/jira/browse/CXF-1455

This also adds the provider to the list of default providers which I presume
is needed for the spec.

Barry

On Thu, Feb 28, 2008 at 11:00 AM, Sergey Beryozkin <
sergey.beryozkin@iona.com> wrote:

> Hi Barry
>
> This is great. Perhaps you may still want to support Map<String, String>
> as well, I was wrong suggesting it would spec uncompliant, the spec requires
> MultivaluedMap<String, String>, but as long as there's a provider to support
> Map<String, String>, then it would be fine...
>
> The only possible problem with Map<String, String>, is that, as far as I
> rememeber, one may have mutiple values for a given key in a form request :
>
> input=bar&input=foo, thus a String value will make it more difficult to
> handle such cases.
>
> MultivaluedMap<String, String> is really a Map<String, List<String>>. It
> has methods like getSingle, so if you know that in your own application no
> multiple values are possible, then you can use getSingle() to avoid dealing
> with Lists.
> From the provider's perspective, perhaps add(key, value) should be used,
> as it will append values to the list if it already exists
>
> Thanks, Sergey
>
>
> > Thanks Sergey,
> >
> > I've created a sub task for this:
> > https://issues.apache.org/jira/browse/CXF-1455
> >
> > I'll tidy up my code, change it to use MultivaluedMap and create a
> patch.
> >
> > Barry
>
> ----------------------------
> IONA Technologies PLC (registered in Ireland)
> Registered Number: 171387
> Registered Address: The IONA Building, Shelbourne Road, Dublin 4, Ireland
>

------=_Part_19392_8520950.1204545291093--