Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cxf-dev@incubator.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
From: Daniel Kulp <dkulp@apache.org>
To: cxf-dev@incubator.apache.org
Subject: Re: svn commit: r641692
 =?iso-8859-1?q?-=09/incubator/cxf/trunk/common/common/src/main/java/org/a?=
 =?iso-8859-1?q?pache/cxf/helpers/IOUtils=2Ejava?=
Date: Wed, 26 Mar 2008 23:08:31 -0400
User-Agent: KMail/1.9.7
References: <20080327022647.46DFC1A9832@eris.apache.org>
 <1206585081.32725.1.camel@gmazza-desktop> <47EB0BB1.4030809@gmail.com>
In-Reply-To: <47EB0BB1.4030809@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200803262308.31284.dkulp@apache.org>


That's actually a good point.  If you follow the instructions for setting 
up eclipse at:

http://cwiki.apache.org/confluence/display/CXF/Setting+up+Eclipse

then eclipse will handle all the checkstyle, pmd, compiler warnings, 
etc...    Basically, if you see any warnings/errors in eclipse, 
something is wrong.   The CXF projects are 100% warning/error free in 
eclipse.

That's pretty much how I work.   Since eclipse will do all the 
checkstyle/pmd, when I run mvn from the command line, I normally just 
do -Pnochecks.  

Dan


On Wednesday 26 March 2008, Willem Jiang wrote:
> Hi Glen,
>
> If you are using Eclipse to write the Java code , you just need
> install a Check Style plugin[1].
> That will be helpful to let you know the error when you save the code.
> [1] http://eclipse-cs.sourceforge.net/update
>
> Willem
>
> Glen Mazza wrote:
> > Thanks...BTW, what do I need to do get the checkstyle errors
> > *before* I check in the files?  mvn checkstyle:checkstyle
> > none-too-helpfully tells me there are checkstyle errors, but won't
> > tell me what they are.
> >
> > Glen
> >
> > Am Donnerstag, den 27.03.2008, 02:26 +0000 schrieb dkulp@apache.org:
> >> Author: dkulp
> >> Date: Wed Mar 26 19:26:43 2008
> >> New Revision: 641692
> >>
> >> URL: http://svn.apache.org/viewvc?rev=641692&view=rev
> >> Log:
> >> More fixes
> >>
> >> Modified:
> >>    
> >> incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/help
> >>ers/IOUtils.java
> >>
> >> Modified:
> >> incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/help
> >>ers/IOUtils.java URL:
> >> http://svn.apache.org/viewvc/incubator/cxf/trunk/common/common/src/
> >>main/java/org/apache/cxf/helpers/IOUtils.java?rev=641692&r1=641691&r
> >>2=641692&view=diff
> >> ===================================================================
> >>=========== ---
> >> incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/help
> >>ers/IOUtils.java (original) +++
> >> incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/help
> >>ers/IOUtils.java Wed Mar 26 19:26:43 2008 @@ -36,7 +36,7 @@
> >>      }
> >>
> >>      public static int copy(final InputStream input, final
> >> OutputStream output) -            throws IOException {
> >> +        throws IOException {
> >>          return copy(input, output, DEFAULT_BUFFER_SIZE);
> >>      }
> >>
> >> @@ -95,7 +95,7 @@
> >>      }
> >>
> >>      public static String toString(final InputStream input, int
> >> bufferSize) -            throws IOException {
> >> +        throws IOException {
> >>
> >>          int avail = input.available();
> >>          if (avail > bufferSize) {
> >> @@ -129,7 +129,7 @@
> >>      }
> >>
> >>      public static String readStringFromStream(InputStream in)
> >> -            throws IOException {
> >> +        throws IOException {
> >>
> >>          StringBuilder sb = new StringBuilder(1024);
> >>
> >> @@ -151,7 +151,7 @@
> >>       * @throws IOException
> >>       */
> >>      public static ByteArrayInputStream loadIntoBAIS(InputStream
> >> in) -            throws IOException {
> >> +        throws IOException {
> >>          int i = in.available();
> >>          if (i < DEFAULT_BUFFER_SIZE) {
> >>              i = DEFAULT_BUFFER_SIZE;


-- 
J. Daniel Kulp
Principal Engineer, IONA
dkulp@apache.org
http://www.dankulp.com/blog