Return-Path: Delivered-To: apmail-incubator-cxf-dev-archive@locus.apache.org Received: (qmail 10074 invoked from network); 27 Mar 2008 02:37:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Mar 2008 02:37:39 -0000 Received: (qmail 81997 invoked by uid 500); 27 Mar 2008 02:37:38 -0000 Delivered-To: apmail-incubator-cxf-dev-archive@incubator.apache.org Received: (qmail 81972 invoked by uid 500); 27 Mar 2008 02:37:38 -0000 Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cxf-dev@incubator.apache.org Delivered-To: mailing list cxf-dev@incubator.apache.org Received: (qmail 81956 invoked by uid 99); 27 Mar 2008 02:37:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Mar 2008 19:37:38 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [64.79.199.57] (HELO server.dankulp.com) (64.79.199.57) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Mar 2008 02:36:45 +0000 Received: by server.dankulp.com (Postfix, from userid 5000) id 4A6E7197C4EF; Wed, 26 Mar 2008 22:37:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on server.dankulp.com X-Spam-Level: X-Msg-File: /tmp/mailfilter.XXXXJpGs0H Received: from dilbert.hsd1.ma.comcast.net (c-24-147-10-180.hsd1.ma.comcast.net [24.147.10.180]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.dankulp.com (Postfix) with ESMTP id 025DD197C491; Wed, 26 Mar 2008 22:37:01 -0400 (EDT) From: Daniel Kulp To: cxf-dev@incubator.apache.org Subject: Re: svn commit: r641692 - /incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/helpers/IOUtils.java Date: Wed, 26 Mar 2008 22:37:00 -0400 User-Agent: KMail/1.9.7 Cc: Glen Mazza References: <20080327022647.46DFC1A9832@eris.apache.org> <1206585081.32725.1.camel@gmazza-desktop> In-Reply-To: <1206585081.32725.1.camel@gmazza-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803262237.00667.dkulp@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Status: No, score=0.5 required=3.0 tests=BAYES_00,RCVD_IN_PBL, RCVD_IN_SORBS_DUL,RDNS_DYNAMIC,TW_DK,TW_MV,TW_SV autolearn=no version=3.2.4 On Wednesday 26 March 2008, Glen Mazza wrote: > Thanks...BTW, what do I need to do get the checkstyle errors *before* > I check in the files? mvn checkstyle:checkstyle none-too-helpfully > tells me there are checkstyle errors, but won't tell me what they are. Just "mvn install" without any profiles set should do it. You actually can do "mvn validate" which will run the PMD and checkstyle stuff (since we have them configured to run in the validate phase). Basically, don't do -Pfastinstall or -Pnochecks. There is a -Psourcecheck profile which is what invokes it, but that is "activeByDefault" so shouldn't need to be specified. Dan > Glen > > Am Donnerstag, den 27.03.2008, 02:26 +0000 schrieb dkulp@apache.org: > > Author: dkulp > > Date: Wed Mar 26 19:26:43 2008 > > New Revision: 641692 > > > > URL: http://svn.apache.org/viewvc?rev=641692&view=rev > > Log: > > More fixes > > > > Modified: > > > > incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/helpe > >rs/IOUtils.java > > > > Modified: > > incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/helpe > >rs/IOUtils.java URL: > > http://svn.apache.org/viewvc/incubator/cxf/trunk/common/common/src/m > >ain/java/org/apache/cxf/helpers/IOUtils.java?rev=641692&r1=641691&r2= > >641692&view=diff > > ==================================================================== > >========== --- > > incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/helpe > >rs/IOUtils.java (original) +++ > > incubator/cxf/trunk/common/common/src/main/java/org/apache/cxf/helpe > >rs/IOUtils.java Wed Mar 26 19:26:43 2008 @@ -36,7 +36,7 @@ > > } > > > > public static int copy(final InputStream input, final > > OutputStream output) - throws IOException { > > + throws IOException { > > return copy(input, output, DEFAULT_BUFFER_SIZE); > > } > > > > @@ -95,7 +95,7 @@ > > } > > > > public static String toString(final InputStream input, int > > bufferSize) - throws IOException { > > + throws IOException { > > > > int avail = input.available(); > > if (avail > bufferSize) { > > @@ -129,7 +129,7 @@ > > } > > > > public static String readStringFromStream(InputStream in) > > - throws IOException { > > + throws IOException { > > > > StringBuilder sb = new StringBuilder(1024); > > > > @@ -151,7 +151,7 @@ > > * @throws IOException > > */ > > public static ByteArrayInputStream loadIntoBAIS(InputStream in) > > - throws IOException { > > + throws IOException { > > int i = in.available(); > > if (i < DEFAULT_BUFFER_SIZE) { > > i = DEFAULT_BUFFER_SIZE; -- J. Daniel Kulp Principal Engineer, IONA dkulp@apache.org http://www.dankulp.com/blog