Mailing-List: contact cxf-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cxf-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of barfitzgerald@gmail.com
 designates 209.85.198.191 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=gC5slzG2XT/mg7+Da6INeEvmmVFc9mK3tRndJu/zd2cd1j9m/vn2gKlMJzNGvGh5762HlT2xiWGbx0zNPz/tqqXeBrbPkU+qZvcV8J7sE4C/+8DLXdDGLrCwkYikt/iDaXLi6HUSM1HQnabngkYMeBU/OEUA+1bwzHnJEZ6XaM0=
Message-ID: <6f5a2e920802070915p336c42b0s514c935e153c922d@mail.gmail.com>
Date: Thu, 7 Feb 2008 17:15:47 +0000
From: "Barry Fitzgerald" <barfitzgerald@gmail.com>
To: cxf-dev@incubator.apache.org
Subject: Re: Patch for JAX-RS Spring configuration [CXF-1416]
In-Reply-To: 
 <7C9FE14C002B5D47BF50AE3B2C376FA1024F9C2D@emea-ems1.IONAGLOBAL.COM>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_18215_15403647.1202404547868"
References: <6f5a2e920802061304t63d480d3o6449b06e68110e9f@mail.gmail.com>
	 <7C9FE14C002B5D47BF50AE3B2C376FA1024F9C2D@emea-ems1.IONAGLOBAL.COM>

------=_Part_18215_15403647.1202404547868
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

I've added a patch to Jira now that includes a test. Both patches still need
to applied - one for the code, one for the test.

Thanks,

Barry

On Feb 7, 2008 10:09 AM, Beryozkin, Sergey <Sergey.Beryozkin@iona.com>
wrote:

> Hi Barry
>
> Thanks for the explanation. I've also read the Jervis's comments, so it
> does make sense. It's useful to define multiple (root) resources
> possibly sharing the same configuration.
> I had a minor concern, which was purely about the syntax :
>
> > > <jaxrs:server id="customerService" address="/">
> > >        <jaxrs:serviceBeans>
> > >            <!--multiple services support -->
> > >            <ref bean="restfulUserService" />
> > >            <ref bean="restfulLoginService" />
> > >        </jaxrs:serviceBeans>
> > >    </jaxrs:server>
>
> It just says me that a customer service is a master service.
> But then, may be, this is exactly what a user wants to express, to show
> this sort of relationship...
>
> Cheers, Sergey
>
> -----Original Message-----
> From: Barry Fitzgerald [mailto:barfitzgerald@gmail.com]
> Sent: 06 February 2008 21:05
> To: cxf-dev@incubator.apache.org
> Subject: Re: Patch for JAX-RS Spring configuration [CXF-1416]
>
> Hi Sergey,
>
> Thanks for the comment. My rational is as follows:
>
>   - The spring config method should closely mirror the non-spring
> config
>   method.
>   - There may be many situations where your server is customised in
> some
>   way e.g. injected interceptors - I think in these cases it wouldn't
>   make sense to have multiple servers defined each with the same
>   customisation.
>   - While some scenarios may be covered by sub-resources, in many this
>   is not applicable.
>   - Finally this the patch allows the choice to inject multiple root
>   resources or not, allowing one to choose their ideal approach.
>
> In short it's no show stopper but I think it is useful functionality.
>
> Barry
>
> On Feb 6, 2008 4:13 PM, Sergey Beryozkin <sergey.beryozkin@iona.com>
> wrote:
>
> > Hi
> >
> > So what sort of problem this patch  is trying to address ?
> > Why can't a user do :
> >
> > <jaxrs:server id="customerService" address="/">
> > </jaxrs:server>
> >
> > <jaxrs:server id="restfulUserService" address="/user">
> > </jaxrs:server>
> >
> > The proposed configuration makes me think that, in this case, a
> > restfulUserService is a subresource...
> >
> > Cheers, Sergey
> >
> > > Hi,
> > >
> > > I've created a patch for CXF-1416. It now enables multiple root
> > resources to
> > > be configured.
> > >
> > > https://issues.apache.org/jira/browse/CXF-1416
> > >
> > > I've tested this manually with the following similar config to
> below:
> > >
> > > <jaxrs:server id="customerService" address="/">
> > >        <jaxrs:serviceBeans>
> > >            <!--multiple services support -->
> > >            <ref bean="restfulUserService" />
> > >            <ref bean="restfulLoginService" />
> > >        </jaxrs:serviceBeans>
> > >    </jaxrs:server>
> > >
> > > There are currently no tests for the Spring bean definition parser
> that
> > I
> > > can see and I'm not sure exactly how to write a valid unit test for
> > this.
> > > Maybe someone can enlighten me!
> > >
> > > Thanks,
> > >
> > > Barry
> > >
> >
> > ----------------------------
> > IONA Technologies PLC (registered in Ireland)
> > Registered Number: 171387
> > Registered Address: The IONA Building, Shelbourne Road, Dublin 4,
> Ireland
> >
>
> ----------------------------
> IONA Technologies PLC (registered in Ireland)
> Registered Number: 171387
> Registered Address: The IONA Building, Shelbourne Road, Dublin 4, Ireland
>

------=_Part_18215_15403647.1202404547868--