cxf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: svn commit: r593444 - in /incubator/cxf/trunk: api/src/main/java/org/apache/cxf/ws/addressing/ rt/core/src/main/java/org/apache/cxf/interceptor/ rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/ systests/src/test/java/org/apache/cxf/systest/ws/add...
Date Fri, 09 Nov 2007 22:33:50 GMT
On Friday 09 November 2007, Glen Mazza wrote:
> Am Freitag, den 09.11.2007, 07:48 +0000 schrieb mmao@apache.org:
> >      private int limit = 100 * 1024;
> > +    private boolean enabled;
>
> While it may be that "enabled" will be false by default, it is usually
> better for readability to initialize that explicitly.  The reader is
> never sure if "false" was the coder's intent, or that they simply
> forgot to initialize this variable.

The PMD rules will prevent that.  Initializing values to the default 
values just wastes processor time at construction time.


-- 
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727    C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog

Mime
View raw message